n-api: update reference test

Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. Backport-PR-URL: #19265 PR-URL: #19086 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Author: Gabriel Schulhof

test/addons-napi/test_reference/test_reference.c

@@ -1,6 +1,5 @@
 #include<node_api.h>
 #include"../common.h"
-#include<stdlib.h>
 
 staticinttest_value=1;
 staticintfinalize_count=0;
@@ -13,7 +12,9 @@ napi_value GetFinalizeCount(napi_env env, napi_callback_info info){
 }
 
 voidFinalizeExternal(napi_envenv, void*data, void*hint){
-free(data);
+int*actual_value=data;
+NAPI_ASSERT_RETURN_VOID(env, actual_value==&test_value,
+"The correct pointer was passed to the finalizer");
 finalize_count++;
 }
 
@@ -33,13 +34,10 @@ napi_value CreateExternal(napi_env env, napi_callback_info info){
 }
 
 napi_valueCreateExternalWithFinalize(napi_envenv, napi_callback_infoinfo){
-int*data=malloc(sizeof(int));
-*data=test_value;
-
 napi_valueresult;
 NAPI_CALL(env,
 napi_create_external(env,
-data,
+&test_value,
 FinalizeExternal,
 NULL, /* finalize_hint */
 &result));