n-api: update reference test#19086
Closed
n-api: update reference test #19086
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer.
nodejs-github-bot added dont-land-on-v4.x node-api 
ContributorAuthor
gabrielschulhof commented Mar 2, 2018
cjihrig approved these changes Mar 2, 2018
jasnell approved these changes Mar 2, 2018
BridgeAR added the author ready 
tniessen approved these changes Mar 4, 2018
ContributorAuthor
gabrielschulhof commented Mar 4, 2018
The CI seems to have died. Here's a new one: |
ContributorAuthor
gabrielschulhof commented Mar 4, 2018
node-test-commit-arm-fanned seems flaky. I will land this. |
ContributorAuthor
gabrielschulhof commented Mar 4, 2018
Landed in d83f830. |
gabrielschulhof pushed a commit that referenced this pull request Mar 4, 2018
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. PR-URL: #19086 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Mar 5, 2018
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. PR-URL: nodejs#19086 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 12, 2018
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. PR-URL: nodejs#19086 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. PR-URL: nodejs#19086 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. Backport-PR-URL: #19447 PR-URL: #19086 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request May 1, 2018
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. Backport-PR-URL: #19265 PR-URL: #19086 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Remove the necessity for allocating on the heap, and assert that the correct pointer gets passed to the finalizer. PR-URL: nodejs#19086 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the necessity for allocating on the heap, and assert that the
correct pointer gets passed to the finalizer.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api