v9.8.0 proposal#19181
Merged
v9.8.0 proposal #19181
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently, when configured --without-ssl test-repl-tab-complete fails with the following error: assert.js:43 throw new errors.AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: [ [], 'lexicalL' ] deepStrictEqual [] at testRepl.complete.common.mustCall (node/test/parallel/test-repl-tab-complete.js:549:14) at /node/test/common/index.js:530:15 at completionGroupsLoaded (repl.js:1204:5) at REPLServer.complete (repl.js:1090:11) at REPLServer.completer (repl.js:450:14) at REPLServer.complete (repl.js:919:18) at __dirname.forEach (parallel/test-repl-tab-complete.js:548:14) at Array.forEach (<anonymous>) at Object.<anonymous> (parallel/test-repl-tab-complete.js:545:29) at Module._compile (module.js:660:30) This commit attempts to fix this test but I'm not sure if this is a proper fix as I'm not familiar with the repl code base yet. PR-URL: #17867 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #18875 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #17690 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #18895 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #18981Fixes: #18978 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #18928 Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
There are two minor issues in the AsyncHook constructor, if the object passed in has an after and/or destroy property that are not functions the errors thrown will still be: TypeError [ERR_ASYNC_CALLBACK]: before must be a function This commit updates the code and adds a unit test. PR-URL: #19000 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
PR-URL: #18958Fixes: #18938 Ref: nodejs/build#1145 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
PR-URL: #18949Fixes: #18948 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]>
When socket is closed on a response for a request that is being piped to a stream there is a condition where aborted event will be fired to http client when socket is closing and the incomingMessage stream is still set to readable. We need a check for request being complete and to only raise the 'aborted' event on the http client if we have not yet completed reading the response from the server. Fixes: #18756 PR-URL: #18999 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Tests in progress to reproduce issue consistently. Fixes: #18756 PR-URL: #18999 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #18999 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. PR-URL: #19049 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #19052 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #19053 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Send a human-readable HTTP/1 response in case of an unexpected ALPN protocol. This helps with debugging this condition, since previously the only result of it would be a closed socket. PR-URL: #18986 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Make the test for pending deprecations work when the env var is set during the whole test suite run. PR-URL: #18991 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Previously, if `session.destroy()` was called with an error object, the information contained in it would be discarded and a generic `ERR_HTTP2_STREAM_CANCEL` would be used for all pending streams. Instead, make the information from the original error object available. PR-URL: #18988 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #18924Fixes: #18169 Refs: #18673 Refs: https://github.com/nodejs/node/blob/v9.5.0/src/node_http2.cc#L1481-L1484 Refs: https://github.com/nodejs/node/blob/v9.5.0/lib/_http_outgoing.js#L659-L661 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Refs: #18673 PR-URL: #18924 Refs: #18673 Refs: https://github.com/nodejs/node/blob/v9.5.0/src/node_http2.cc#L1481-L1484 Refs: https://github.com/nodejs/node/blob/v9.5.0/lib/_http_outgoing.js#L659-L661 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
`async` and `bytes` are only interesting when the write is coming from JS, and unnecessary otherwise. Also, make all of the stream `Write*()` bindings use the same code for setting these, and upgrade to the non-deprecated versions. PR-URL: #18963 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Passing a pointer to a static integer is sufficient for the test. PR-URL: #19039 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]>
PR-URL: #18080 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
libuv and zlib symbols are also purposefully re-exported by Node.js for use in Addons. Refs: #17444 PR-URL: #19013 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Use common.platformTimeout() to give longer durations to Raspberry Pi devices to make test more reliable. PR-URL: #18126Fixes: #16772 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
The test was flaky because it relied on a specific order of asynchronous operation that were fired paralellely. This was true on most platform and conditions, but not all the time. See: #18986 PR-URL: #19093 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #19109 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Documentation for N-API Custom Asynchronous Operations incorrectly stated that async execution happens on the main event loop. Added details to napi_create_async_work about which threads are used to invoke the execute and complete callbacks. Changed 'async' to 'asynchronous' in the documentation for Custom Asynchronous Operations. Changed "executes in parallel" to "can execute in parallel" for the documentation of napi_create_async_work execute parameter. PR-URL: #19073Fixes: #19071 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #19126 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
The default message will be printed if the assertion fires. Use block scope for related variables and tests. PR-URL: #19054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Fixes: #17892Fixes: #17893Fixes: #18992 PR-URL: #18993 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
PR-URL: #19162 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Backport-PR-URL: #19185 PR-URL: #18297 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Replace v8::Persistent with node::Persistent, a specialization that resets the persistent handle on destruction. Prevents accidental resource leaks when forgetting to call .Reset() manually. I'm fairly confident this commit fixes a number of resource leaks that have gone undiagnosed so far. Backport-PR-URL: #19185 PR-URL: #18656 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
The previous commit made persistent handles auto-reset on destruction. This commit removes the Reset() calls that are now no longer necessary. Backport-PR-URL: #19185 PR-URL: #18656 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Don't try to update the internal field pointer of the JS object in the destructor. The garbage collector invokes the destructor when the object is collected and is not necessarily in a valid state anymore. Backport-PR-URL: #19185 PR-URL: #18656 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
This fixes a crash that occurred when a `Http2Stream` write is completed after it is already destroyed. Instead, don’t destroy the stream in that case and wait for GC to take over. Backport-PR-URL: #19185 PR-URL: #19002Fixes: #18973 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
This adds support for ensuring that the top-level main into Node is supported loading when it has no extension for backwards-compat with NodeJS bin workflows. In addition package.json caching is implemented in the module lookup process. Backport-PR-URL: #18923 PR-URL: #18728 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Backport-PR-URL: #18923 PR-URL: #18788 Refs: #18728 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Backport-PR-URL: #19180 PR-URL: #18925 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
We have two notes in API docs about Android support: the first has no links, the second links to the table of supported OSs where Android is not mentioned which may be confusing. This PR makes both notes link to dedicated Android part of BUILDING.md. Backport-PR-URL: #19183 PR-URL: #19004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Backport-PR-URL: #19194 PR-URL: #18607 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorinsforce-pushed the v9.8.0-proposal branch from 12e4454 to 3e9be23CompareMylesBorins added a commit that referenced this pull request Mar 7, 2018
Notable Changes: * crypto: - add cert.fingerprint256 as SHA256 fingerprint (Hannes Magnusson) #17690 * lib: - v8_prof_processor works again 🎉 (Anna Henningsen) #19059 * loader: - --inspect-brk now works properly for esmodules (Gus Caplan) #18949 * src: - handle exceptions in env-\>SetImmediates (James M Snell) #18297 - make process.dlopen() load well-known symbol (Ben Noordhuis) #18934 * trace_events: - add file pattern cli option (Andreas Madsen) #18480 PR-URL: #19181
ContributorAuthor
MylesBorins commented Mar 7, 2018
I've backed out the offended V8 change and landed a few more backports CI: https://ci.nodejs.org/job/node-test-pull-request/13573/ |
Member
addaleax commented Mar 7, 2018
@MylesBorins I wouldn’t put it in the notable changes section. It doesn’t actually work yet, it’s been broken for quite a while for some other reason that we still have to get into. What my patch did was only fixing part of that, and I think it’s not usable again (yet). |
Member
addaleax commented Mar 7, 2018
Also not really a notable change, tbh … before the other commits from the same PR, there were no such exceptions happening at all, and we’re not backporting the rest of the PR. It’s really only backported to v9.x to avoid merge conflicts. :) (We can also remove the
I think some of the others in @nodejs/release always include these as notable changes?
I think you can call these out as notable changes. Something like “Fixed issues with aborted connections in the HTTP/2 implementation.” should be fine? |
Member
addaleax commented Mar 7, 2018
Correcting myself here: Okay, it appears to be partially working, but the tests still fail on |
MylesBorinsforce-pushed the v9.8.0-proposal branch from 3e9be23 to 5d2dccdCompareNotable Changes: * crypto: - add cert.fingerprint256 as SHA256 fingerprint (Hannes Magnusson) #17690 * http2: - Fixed issues with aborted connections in the HTTP/2 implementation (Anna Henningsen) #18987#19002 * loader: - --inspect-brk now works properly for esmodules (Gus Caplan) #18949 * src: - make process.dlopen() load well-known symbol (Ben Noordhuis) #18934 * trace_events: - add file pattern cli option (Andreas Madsen) #18480 * Added new collaborators: - Chen Gang (MoonBall) https://github.com/MoonBall PR-URL: #19181
MylesBorinsforce-pushed the v9.8.0-proposal branch from 5d2dccd to 27ba6e2CompareContributorAuthor
MylesBorins commented Mar 7, 2018
Updated the changelog as requested. Also fixed minor linting error (doc related). CITGM looks good just waiting for last arm to finish running |
MylesBorins added a commit that referenced this pull request Mar 8, 2018
Notable Changes: * crypto: - add cert.fingerprint256 as SHA256 fingerprint (Hannes Magnusson) #17690 * http2: - Fixed issues with aborted connections in the HTTP/2 implementation (Anna Henningsen) #18987#19002 * loader: - --inspect-brk now works properly for esmodules (Gus Caplan) #18949 * src: - make process.dlopen() load well-known symbol (Ben Noordhuis) #18934 * trace_events: - add file pattern cli option (Andreas Madsen) #18480 * Added new collaborators: - Chen Gang (MoonBall) https://github.com/MoonBall PR-URL: #19181
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Notable Changes: * crypto: - add cert.fingerprint256 as SHA256 fingerprint (Hannes Magnusson) nodejs#17690 * http2: - Fixed issues with aborted connections in the HTTP/2 implementation (Anna Henningsen) nodejs#18987nodejs#19002 * loader: - --inspect-brk now works properly for esmodules (Gus Caplan) nodejs#18949 * src: - make process.dlopen() load well-known symbol (Ben Noordhuis) nodejs#18934 * trace_events: - add file pattern cli option (Andreas Madsen) nodejs#18480 * Added new collaborators: - Chen Gang (MoonBall) https://github.com/MoonBall PR-URL: nodejs#19181
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2018-03-07, Version 9.8.0 (Current), @MylesBorins
Notable Changes
Commits
6ae2cafde3] - buffer: coerce offset to integer (Ruben Bridgewater) #182156d17383041] - buffer: fix typo in lib/buffer.js (Ujjwal Sharma) #191264b34b2e185] - build: fix gocvr version used for coverage (Michael Dawson) #19094a938e52ffe] - build: disable openssl build warnings on macos (Ben Noordhuis) #1904644d80c5620] - build: fix coverage after gcovr update (killagu) #1895828a5362e83] - build: fix lint-md-build dependency (Joyee Cheung) #18981e74e422a53] - (SEMVER-MINOR)crypto: add cert.fingerprint256 as SHA256 fingerprint (Hannes Magnusson) #17690056001dc8f] - (SEMVER-MINOR)deps: cherry-pick 0bcb1d6f from upstream V8 (Jakob Kummerow) #18212630a6533b0] - doc: add new documentation rule (estrada9166) #187261fadb2edb4] - doc: fix/add link to Android info (Vse Mozhet Byt) #1900468524610f2] - doc: remove subsystem from pull request template (Rich Trott) #19125d3a70e9cd4] - doc: remove tentativeness in pull-requests.md (Rich Trott) #19123f03079fce6] - doc: update cc list (Ruben Bridgewater) #190999d2de16b13] - doc: add introduced_in metadata to _toc.md (Rich Trott) #19113ae2dabb8fc] - doc: new team for bundlers or delivery of Node.js (Michael Dawson) #190980e4f4266a1] - doc: add simple example to rename function (punteek) #18812e42600fc4b] - doc: add missingReturnsin fs & util (Sho Miyamoto) #187754ecf5bbe74] - doc: fix a typo in util.isDeepStrictEqual (Sho Miyamoto) #18775cab6c8e95c] - doc: add URL.format() example (Zeke Sikelianos) #18888a4462b7944] - doc: fix n-api asynchronous threading docs (Eric Bickle) #19073bfa894cf37] - doc: add MoonBall to collaborators (Chen Gang) #1910977154cd65d] - doc: update list of re-exported symbols (Richard Lau) #19013459f2095a1] - doc: Readable unpipe on Writable error event (George Sapkin) #1808068c1337819] - doc: add RegExp Unicode Property Escapes to intl (Vse Mozhet Byt) #1905271d09ecbf1] - doc: make the background section concise and improve its formality (Wilson) #18928951054004d] - doc: lowercase primitives in test/common/README.md (Vse Mozhet Byt) #188755b8c97f6bc] - events: show throw stack trace for uncaught exception (Anna Henningsen) #190030789eeceb6] - http: prevent aborted event when already completed (Andrew Johnston) #18999ae4d83facf] - http: prevent aborted event when already completed (Andrew Johnston) #1899950d1233935] - http2: no stream destroy while its data is on the wire (Anna Henningsen) #19002551d9752c8] - http2: fix flaky test-http2-https-fallback (Matteo Collina) #190938bc930c269] - http2: fix endless loop when writing empty string (Anna Henningsen) #18924aa0fca9426] - http2: use original error for cancelling pending streams (Anna Henningsen) #18988447136999d] - http2: send error text in case of ALPN mismatch (Anna Henningsen) #18986ef8f90f34e] - http2: fix condition where data is lost (Matteo Collina) #18895e584113b66] - lib: re-fix v8_prof_processor (Anna Henningsen) #1905912856b0dd2] - lib: change hook -> hooks in code comment (Daniel Bevenius) #19053db8d197e79] - lib,test: remove yoda statements (Ruben Bridgewater) #1874659547cc438] - loader: fix --inspect-brk (Gus Caplan) #1894939e032fe86] - module: fix main lookup regression from esm: Add support for pjson cache and main without extensions #18728 (Guy Bedford) #18788f3e3429296] - module: support main w/o extension, pjson cache (Guy Bedford) #1872895f6467ffd] - module: fix cyclical dynamic import (Bradley Farias) #189655c4f703607] - n-api: update reference test (Gabriel Schulhof) #190861b32fc3276] - n-api: fix object test (Gabriel Schulhof) #19039ef4714c2b6] - net: inline and simplify onSocketEnd (Anna Henningsen) #1860728880cf89d] - perf_hooks: fix timing (Timothy Gu) #1899396f0bec48b] - repl: make last error available as\_error(Anna Henningsen) #18919420d56c2ea] - src: don't touch js object in Http2Session dtor (Ben Noordhuis) #18656f89f659dcf] - src: remove unnecessary Reset() calls (Ben Noordhuis) #1865667a9742aed] - src: prevent persistent handle resource leaks (Ben Noordhuis) #1865608bcdde888] - (SEMVER-MINOR)src: handle exceptions in env->SetImmediates (James M Snell) #18297cc52dae7c4] - src: #include <stdio.h>" to iculslocs (Steven R. Loomis) #191502f17c52674] - src: use std::unique_ptr for STACK_OF(X509) (Ben Noordhuis) #19087f10470ce2d] - src: refactor GetPeerCertificate (Daniel Bevenius) #190874fae6e3904] - (SEMVER-MINOR)src: make process.dlopen() load well-known symbol (Ben Noordhuis) #1893489edbae7ab] - (SEMVER-MINOR)src: clean up process.dlopen() (Ben Noordhuis) #1893408b83ee27a] - src: refactor setting JS properties on WriteWrap (Anna Henningsen) #189634d5cd5c6c5] - src: fix error message in async_hooks constructor (Daniel Bevenius) #190006787913a68] - test: add more information to assert.strictEqual (Ujjwal Sharma) #19162ee653ecd09] - test: move require http2 to after crypto check (Daniel Bevenius) #191115bbf009c1d] - test: check symbols in shared lib (Yihong Wang) #18806d8833762cb] - test: refactor test-async-wrap-getasyncid (Santiago Gimeno) #1872723107ba7b1] - test: remove assert message and add block scope (wuweiweiwu) #19054cc90bbd0f4] - test: fix flaky inspector-stop-profile-after-done (Rich Trott) #181268d595bb25c] - test: check endless loop while writing empty string (XadillaX) #18924a4550069ca] - test: allow running withNODE\_PENDING\_DEPRECATION(Anna Henningsen) #18991fd27165f73] - test: specify 'dir' for directory symlinks (Kyle Farnung) #19049eca333a6e8] - test: refactor test after review (Andrew Johnston) #18999c943cd09a7] - test: fix repl-tab-complete --without-ssl (Daniel Bevenius) #17867f864509991] - test,benchmark: use new Buffer API where appropriate (Сковорода Никита Андреевич) #18980479b622e49] - tls,http2: handle writes after SSL destroy more gracefully (Anna Henningsen) #189873d4cda3a7d] - (SEMVER-MINOR)trace_events: add file pattern cli option (Andreas Madsen) #184803e8e1524ac] - util: use blue on non-windows systems for number (Gus Caplan) #18925