[v9.x backport] module: main w/o extension, pjson cache (#18728, #18788)#18923
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added lib / src 
guybedford commented Feb 27, 2018
I'd like to reopen this for consideration against #19040. |
guybedford commented Feb 27, 2018
guybedford changed the title 
rvagg commented Mar 1, 2018
@MylesBorins re your comments in our TSC meeting about modules work going on, I'm guessing that we may want to hold off on pushing this kind of change out via Current just now until the modules group gets a chance to get its footing and make some more comprehensive decisions about ESM? |
guybedford commented Mar 1, 2018
@rvagg thanks for checking on this one. It does fix a backwards compatibility concern so that's the main reason I'm pushing it. This is relatively non-controversial so shouldn't be too much of an issue I'd expect, but will be interesting to hear what Myles thinks as well. The main blocker at the moment though is that CI is failing and I haven't had a moment to look into this further...! If I can't get to the fix in time, no problem at all to skip this for now. |
This adds support for ensuring that the top-level main into Node is supported loading when it has no extension for backwards-compat with NodeJS bin workflows. In addition package.json caching is implemented in the module lookup process. PR-URL: nodejs#18728 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#18788 Refs: nodejs#18728 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
guybedford commented Mar 4, 2018
I finally fixed the issue here. |
This adds support for ensuring that the top-level main into Node is supported loading when it has no extension for backwards-compat with NodeJS bin workflows. In addition package.json caching is implemented in the module lookup process. Backport-PR-URL: #18923 PR-URL: #18728 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Backport-PR-URL: #18923 PR-URL: #18788 Refs: #18728 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins commented Mar 7, 2018
landed in 50d1233...39e032f |
4 participants
This includes the v9 backports for #18728 and #18788.
The conflict resolution is only in the first commit for #18728 here.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes