Skip to content

tls,http2: handle writes after SSL destroy more gracefully#18987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

tls,http2: handle writes after SSL destroy more gracefully #18987

addaleax wants to merge 1 commit into from
+38 −7

Conversation

@addaleax
Copy link
Member

@addaleaxaddaleax commented Feb 25, 2018•
edited
Loading

This might otherwise result in a hard crash when trying
to write to a socket after a sudden disconnect.

Note that the test here uses an aborted h2load run to create
the failing requests; That’s far from ideal, but it provides
a reasonably reliably reproduction at this point.

Fixes: #18973

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tls

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem. labels Feb 25, 2018
This was referenced Feb 25, 2018
Closed
Closed
@addaleax
Copy link
MemberAuthor

addaleax commented Feb 25, 2018

CI: https://ci.nodejs.org/job/node-test-commit/16488/

@addaleax
tls,http2: handle writes after SSL destroy more gracefully
d1f9ace
This might otherwise result in a hard crash when trying to write to a socket after a sudden disconnect. Note that the test here uses an aborted `h2load` run to create the failing requests; That’s far from ideal, but it provides a reasonably reliably reproduction at this point.
@addaleaxaddaleaxforce-pushed the http2-tls-writer-after-socket-abort branch from 28f69ab to d1f9aceCompareFebruary 25, 2018 21:28
mcollina
mcollina approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2018
@addaleax
Copy link
MemberAuthor

addaleax commented Mar 4, 2018

New CI: https://ci.nodejs.org/job/node-test-commit/16657/

@addaleax
Copy link
MemberAuthor

addaleax commented Mar 5, 2018

Landed in 0c25cdf

@addaleaxaddaleax closed this Mar 5, 2018
@addaleaxaddaleax deleted the http2-tls-writer-after-socket-abort branch March 5, 2018 09:40
@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2018
addaleax added a commit that referenced this pull request Mar 5, 2018
@addaleax
tls,http2: handle writes after SSL destroy more gracefully
0c25cdf
This might otherwise result in a hard crash when trying to write to a socket after a sudden disconnect. Note that the test here uses an aborted `h2load` run to create the failing requests; That’s far from ideal, but it provides a reasonably reliably reproduction at this point. PR-URL: #18987Fixes: #18973 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
addaleax added a commit to addaleax/node that referenced this pull request Mar 5, 2018
@addaleax
tls,http2: handle writes after SSL destroy more gracefully
479b622
This might otherwise result in a hard crash when trying to write to a socket after a sudden disconnect. Note that the test here uses an aborted `h2load` run to create the failing requests; That’s far from ideal, but it provides a reasonably reliably reproduction at this point. PR-URL: nodejs#18987Fixes: nodejs#18973 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Mar 6, 2018
Merged
MylesBorins added a commit that referenced this pull request Mar 7, 2018
@MylesBorins
2018-03-07, Version 9.8.0 (Current)
27ba6e2
Notable Changes: * crypto: - add cert.fingerprint256 as SHA256 fingerprint (Hannes Magnusson) #17690 * http2: - Fixed issues with aborted connections in the HTTP/2 implementation (Anna Henningsen) #18987#19002 * loader: - --inspect-brk now works properly for esmodules (Gus Caplan) #18949 * src: - make process.dlopen() load well-known symbol (Ben Noordhuis) #18934 * trace_events: - add file pattern cli option (Andreas Madsen) #18480 * Added new collaborators: - Chen Gang (MoonBall) https://github.com/MoonBall PR-URL: #19181
MylesBorins added a commit that referenced this pull request Mar 8, 2018
@MylesBorins
2018-03-07, Version 9.8.0 (Current)
282e65c
Notable Changes: * crypto: - add cert.fingerprint256 as SHA256 fingerprint (Hannes Magnusson) #17690 * http2: - Fixed issues with aborted connections in the HTTP/2 implementation (Anna Henningsen) #18987#19002 * loader: - --inspect-brk now works properly for esmodules (Gus Caplan) #18949 * src: - make process.dlopen() load well-known symbol (Ben Noordhuis) #18934 * trace_events: - add file pattern cli option (Andreas Madsen) #18480 * Added new collaborators: - Chen Gang (MoonBall) https://github.com/MoonBall PR-URL: #19181
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@addaleax@MayaLekova
tls,http2: handle writes after SSL destroy more gracefully
b0f10e9
This might otherwise result in a hard crash when trying to write to a socket after a sudden disconnect. Note that the test here uses an aborted `h2load` run to create the failing requests; That’s far from ideal, but it provides a reasonably reliably reproduction at this point. PR-URL: nodejs#18987Fixes: nodejs#18973 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@MylesBorins@MayaLekova
2018-03-07, Version 9.8.0 (Current)
1874c27
Notable Changes: * crypto: - add cert.fingerprint256 as SHA256 fingerprint (Hannes Magnusson) nodejs#17690 * http2: - Fixed issues with aborted connections in the HTTP/2 implementation (Anna Henningsen) nodejs#18987nodejs#19002 * loader: - --inspect-brk now works properly for esmodules (Gus Caplan) nodejs#18949 * src: - make process.dlopen() load well-known symbol (Ben Noordhuis) nodejs#18934 * trace_events: - add file pattern cli option (Andreas Madsen) nodejs#18480 * Added new collaborators: - Chen Gang (MoonBall) https://github.com/MoonBall PR-URL: nodejs#19181
addaleax added a commit to addaleax/node that referenced this pull request Sep 18, 2018
@addaleax
tls,http2: handle writes after SSL destroy more gracefully
44da69f
This might otherwise result in a hard crash when trying to write to a socket after a sudden disconnect. Note that the test here uses an aborted `h2load` run to create the failing requests; That’s far from ideal, but it provides a reasonably reliably reproduction at this point. PR-URL: nodejs#18987Fixes: nodejs#18973 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@addaleaxaddaleax mentioned this pull request Sep 18, 2018
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Sep 25, 2018
@addaleax@MylesBorins
tls,http2: handle writes after SSL destroy more gracefully
f5985c7
This might otherwise result in a hard crash when trying to write to a socket after a sudden disconnect. Note that the test here uses an aborted `h2load` run to create the failing requests; That’s far from ideal, but it provides a reasonably reliably reproduction at this point. Backport-PR-URL: #22924 PR-URL: #18987Fixes: #18973 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Merged
@hermanbankenhermanbanken mentioned this pull request Nov 2, 2018
Closed
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
@petoknmpetoknm mentioned this pull request Nov 28, 2018
Closed
@dglittledglittle mentioned this pull request Jan 7, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@jasnelljasnelljasnell approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segmentation fault in http2 module when cancelling download in Chrome

5 participants

@addaleax@mcollina@jasnell@BridgeAR@nodejs-github-bot