zlib: refactor to use primordial instead of <string>.startsWith

rchougule · danielleadams · commit b6f74b0b09d1 · 2021-01-12T07:10:55.000-05:00
PR-URL: #36718 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -37,6 +37,7 @@ const{
 ObjectKeys,
 ObjectSetPrototypeOf,
 ReflectApply,
+ StringPrototypeStartsWith,
 Symbol,
 TypedArrayPrototypeFill,
 Uint32Array,
@@ -786,7 +787,9 @@ function createConvenienceMethod(ctor, sync){
 
 const kMaxBrotliParam = MathMax(...ArrayPrototypeMap(
 ObjectKeys(constants),
- (key) => (key.startsWith('BROTLI_PARAM_') ? constants[key] : 0)
+ (key) => (StringPrototypeStartsWith(key, 'BROTLI_PARAM_') ?
+ constants[key] :
+ 0)
 ));
 
 const brotliInitParamsArray = new Uint32Array(kMaxBrotliParam + 1);
@@ -927,7 +930,7 @@ ObjectDefineProperties(module.exports,{
 // These should be considered deprecated
 // expose all the zlib constants
 for (const bkey of ObjectKeys(constants)){
- if (bkey.startsWith('BROTLI')) continue;
+ if (StringPrototypeStartsWith(bkey, 'BROTLI')) continue;
 ObjectDefineProperty(module.exports, bkey,{
 enumerable: false, value: constants[bkey], writable: false
 });

-Original file line number
+Diff line change
  ObjectKeys,
  ObjectSetPrototypeOf,
  ReflectApply,
 + StringPrototypeStartsWith,
  Symbol,
  TypedArrayPrototypeFill,
  Uint32Array,
 constkMaxBrotliParam=MathMax(...ArrayPrototypeMap(
 ObjectKeys(constants),
 -(key)=>(key.startsWith('BROTLI_PARAM_') ? constants[key] : 0)
 +(key)=>(StringPrototypeStartsWith(key,'BROTLI_PARAM_') ?
 +constants[key] :
 +0)
 ));
 constbrotliInitParamsArray=newUint32Array(kMaxBrotliParam+1);
 // These should be considered deprecated
 // expose all the zlib constants
 for(constbkeyofObjectKeys(constants)){
 -if(bkey.startsWith('BROTLI'))continue;
 +if(StringPrototypeStartsWith(bkey,'BROTLI'))continue;
 ObjectDefineProperty(module.exports,bkey,{
 enumerable: false,value: constants[bkey],writable: false
 });