zlib: refactor to use primordial instead of <string>.startsWith#36718
+5 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Lxxyx approved these changes Jan 1, 2021
Member
Lxxyx left a comment
Lxxyx left a comment There was a problem hiding this comment.
LGTM except one nit.
I suggest the first word of the commit message should be an imperative verb, something like zlib: refactor to use primordials instead of StringPrototypeStartsWith. Refs: #36679 (comment)
rchouguleforce-pushed the zlib_string_primordials branch from fcf85c0 to 0665753Compare
ContributorAuthor
rchougule commented Jan 1, 2021
Ah yes. My bad. Addressed in 0665753 |
rchougule changed the title 
aduh95 approved these changes Jan 1, 2021
Comment on lines +790 to +792
| (key)=>(StringPrototypeStartsWith(key,'BROTLI_PARAM_') ? | ||
| constants[key] : | ||
| 0) |
Contributor
There was a problem hiding this comment.
nit: I find it easier to read on one line, but you can leave it as is if you prefer.
Suggested change
| (key)=>(StringPrototypeStartsWith(key,'BROTLI_PARAM_') ? | |
| constants[key] : | |
| 0) | |
| (key)=> | |
| (StringPrototypeStartsWith(key,'BROTLI_PARAM_') ? constants[key] : 0) |
jasnell approved these changes Jan 2, 2021
Trott approved these changes Jan 2, 2021
PoojaDurgad approved these changes Jan 7, 2021
yashLadha added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jan 9, 2021
Collaborator
nodejs-github-bot commented Jan 9, 2021
Contributor
yashLadha commented Jan 10, 2021
Landed in 7a6af02 |
yashLadha pushed a commit that referenced this pull request Jan 10, 2021
PR-URL: #36718 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Pooja D P <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
PR-URL: #36718 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Pooja D P <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 25, 2021
PR-URL: #36718 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Pooja D P <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #36718 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Pooja D P <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #36718 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Pooja D P <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #36718 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Pooja D P <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes