test: refactor test-http-dns-fail

* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions PR-URL: #10243 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Brian White <[email protected]>

Author: edsadr

test/internet/test-http-dns-fail.js

@@ -5,34 +5,25 @@
  */
 
 constcommon=require('../common');
-varassert=require('assert');
-varhttp=require('http');
-
-varhadError=0;
+constassert=require('assert');
+consthttp=require('http');
 
 functionhttpreq(count){
-if(1<count)return;
+if(count>1)return;
 
-varreq=http.request({
+constreq=http.request({
 host: 'not-a-real-domain-name.nobody-would-register-this-as-a-tld',
 port: 80,
 path: '/',
 method: 'GET'
 },common.fail);
 
-req.on('error',function(e){
-console.log(e.message);
+req.on('error',common.mustCall((e)=>{
 assert.strictEqual(e.code,'ENOTFOUND');
-hadError++;
 httpreq(count+1);
-});
+}));
 
 req.end();
 }
 
 httpreq(0);
-
-
-process.on('exit',function(){
-assert.equal(2,hadError);
-});