test: refactor test-http-dns-fail#10243
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added test 
Member
lance commented Dec 12, 2016
LGTM |
mscdex reviewed Dec 12, 2016
test/internet/test-http-dns-fail.js Outdated
Contributor
There was a problem hiding this comment.
I would suggest changing this to }, 2)); and then getting rid of hadError entirely.
EDIT: Actually after further review I think we can just get rid of hadError entirely without changing this line ...
mscdex reviewed Dec 12, 2016
test/internet/test-http-dns-fail.js Outdated
Contributor
There was a problem hiding this comment.
Would you mind reversing the conditional here to count > 1 while you're in this file? I personally find it much easier to understand when scanning code...
mscdex reviewed Dec 12, 2016
test/internet/test-http-dns-fail.js Outdated
Contributor
There was a problem hiding this comment.
I think this should be removed? I still don't know if we have an official policy on this or not ...
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions
edsadr changed the title 
MemberAuthor
edsadr commented Dec 12, 2016
@mscdex just implemented your suggestions, also removed the |
Contributor
mscdex commented Dec 12, 2016
italoacasas approved these changes Dec 13, 2016
Contributor
mscdex commented Dec 13, 2016
LGTM |
cjihrig approved these changes Dec 13, 2016
lpinca approved these changes Dec 14, 2016
italoacasas commented Dec 14, 2016
Landed 75ac109 Thanks for the contribution. |
italoacasas pushed a commit that referenced this pull request Dec 14, 2016
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions PR-URL: #10243 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 15, 2016
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions PR-URL: #10243 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Brian White <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions PR-URL: #10243 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions PR-URL: #10243 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Brian White <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions PR-URL: #10243 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Brian White <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
refactor test-http-dns-fail.js