Skip to content

Commit baabf3e

Browse files
dnlupBethGriggs
authored andcommitted
benchmark: use let/const instead of var in buffers
PR-URL: #30945 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent 5eafe3b commit baabf3e

File tree

8 files changed

+26
-31
lines changed

8 files changed

+26
-31
lines changed

‎benchmark/buffers/buffer-bytelength.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ const chars = [
1616
];
1717

1818
functionmain({ n, len, encoding }){
19-
varstrings=[];
20-
varresults=[len*16];
19+
letstrings=[];
20+
letresults=[len*16];
2121
if(encoding==='buffer'){
2222
strings=[Buffer.alloc(len*16,'a')];
2323
}else{

‎benchmark/buffers/buffer-compare-instance-method.js‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,47 +12,46 @@ function main({n, size, args }){
1212
constb1=Buffer.alloc(size,'a');
1313
constb0Len=b0.length;
1414
constb1Len=b1.length;
15-
vari;
1615

1716
b1[size-1]='b'.charCodeAt(0);
1817

1918
switch(args){
2019
case2:
2120
b0.compare(b1,0);
2221
bench.start();
23-
for(i=0;i<n;i++){
22+
for(leti=0;i<n;i++){
2423
b0.compare(b1,0);
2524
}
2625
bench.end(n);
2726
break;
2827
case3:
2928
b0.compare(b1,0,b1Len);
3029
bench.start();
31-
for(i=0;i<n;i++){
30+
for(leti=0;i<n;i++){
3231
b0.compare(b1,0,b1Len);
3332
}
3433
bench.end(n);
3534
break;
3635
case4:
3736
b0.compare(b1,0,b1Len,0);
3837
bench.start();
39-
for(i=0;i<n;i++){
38+
for(leti=0;i<n;i++){
4039
b0.compare(b1,0,b1Len,0);
4140
}
4241
bench.end(n);
4342
break;
4443
case5:
4544
b0.compare(b1,0,b1Len,0,b0Len);
4645
bench.start();
47-
for(i=0;i<n;i++){
46+
for(leti=0;i<n;i++){
4847
b0.compare(b1,0,b1Len,0,b0Len);
4948
}
5049
bench.end(n);
5150
break;
5251
default:
5352
b0.compare(b1);
5453
bench.start();
55-
for(i=0;i<n;i++){
54+
for(leti=0;i<n;i++){
5655
b0.compare(b1);
5756
}
5857
bench.end(n);

‎benchmark/buffers/buffer-hex.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,15 @@ const bench = common.createBenchmark(main,{
99

1010
functionmain({ len, n }){
1111
constbuf=Buffer.alloc(len);
12-
vari;
1312

14-
for(i=0;i<buf.length;i++)
13+
for(leti=0;i<buf.length;i++)
1514
buf[i]=i&0xff;
1615

1716
consthex=buf.toString('hex');
1817

1918
bench.start();
2019

21-
for(i=0;i<n;i+=1)
20+
for(leti=0;i<n;i+=1)
2221
Buffer.from(hex,'hex');
2322

2423
bench.end(n);

‎benchmark/buffers/buffer-indexof.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const bench = common.createBenchmark(main,{
2525
});
2626

2727
functionmain({ n, search, encoding, type }){
28-
varaliceBuffer=fs.readFileSync(
28+
letaliceBuffer=fs.readFileSync(
2929
path.resolve(__dirname,'../fixtures/alice.html')
3030
);
3131

‎benchmark/buffers/buffer-iterate.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,23 +29,23 @@ function main({size, type, method, n }){
2929
}
3030

3131
functionbenchFor(buffer,n){
32-
for(vark=0;k<n;k++){
33-
for(vari=0;i<buffer.length;i++){
32+
for(letk=0;k<n;k++){
33+
for(leti=0;i<buffer.length;i++){
3434
assert(buffer[i]===0);
3535
}
3636
}
3737
}
3838

3939
functionbenchForOf(buffer,n){
40-
for(vark=0;k<n;k++){
40+
for(letk=0;k<n;k++){
4141
for(constbofbuffer){
4242
assert(b===0);
4343
}
4444
}
4545
}
4646

4747
functionbenchIterator(buffer,n){
48-
for(vark=0;k<n;k++){
48+
for(letk=0;k<n;k++){
4949
constiter=buffer[Symbol.iterator]();
5050
letcur=iter.next();
5151

‎benchmark/buffers/buffer-swap.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Buffer.prototype.htons = function htons(){
3636
Buffer.prototype.htonl=functionhtonl(){
3737
if(this.length%4!==0)
3838
thrownewRangeError();
39-
for(vari=0;i<this.length;i+=4){
39+
for(leti=0;i<this.length;i+=4){
4040
swap(this,i,i+3);
4141
swap(this,i+1,i+2);
4242
}
@@ -66,7 +66,7 @@ function createBuffer(len, aligned){
6666
functiongenMethod(method){
6767
constfnString=`
6868
return function ${method}(n, buf){
69-
for (var i = 0; i <= n; i++)
69+
for (let i = 0; i <= n; i++)
7070
buf.${method}();
7171
}`;
7272
return(newFunction(fnString))();

‎benchmark/buffers/buffer-tostring.js‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,29 +15,28 @@ function main({encoding, args, len, n }){
1515
if(encoding.length===0)
1616
encoding=undefined;
1717

18-
vari;
1918
switch(args){
2019
case1:
2120
bench.start();
22-
for(i=0;i<n;i+=1)
21+
for(leti=0;i<n;i+=1)
2322
buf.toString(encoding);
2423
bench.end(n);
2524
break;
2625
case2:
2726
bench.start();
28-
for(i=0;i<n;i+=1)
27+
for(leti=0;i<n;i+=1)
2928
buf.toString(encoding,0);
3029
bench.end(n);
3130
break;
3231
case3:
3332
bench.start();
34-
for(i=0;i<n;i+=1)
33+
for(leti=0;i<n;i+=1)
3534
buf.toString(encoding,0,len);
3635
bench.end(n);
3736
break;
3837
default:
3938
bench.start();
40-
for(i=0;i<n;i+=1)
39+
for(leti=0;i<n;i+=1)
4140
buf.toString();
4241
bench.end(n);
4342
break;

‎benchmark/buffers/buffer-write-string.js‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,19 @@ function main({len, n, encoding, args }){
1515
letstart=0;
1616
constbuf=Buffer.allocUnsafe(len);
1717

18-
vari;
19-
2018
switch(args){
2119
case'offset':
2220
string='a'.repeat(Math.floor(len/2));
2321
start=len-string.length;
2422
if(encoding){
2523
bench.start();
26-
for(i=0;i<n;++i){
24+
for(leti=0;i<n;++i){
2725
buf.write(string,start,encoding);
2826
}
2927
bench.end(n);
3028
}else{
3129
bench.start();
32-
for(i=0;i<n;++i){
30+
for(leti=0;i<n;++i){
3331
buf.write(string,start);
3432
}
3533
bench.end(n);
@@ -39,13 +37,13 @@ function main({len, n, encoding, args }){
3937
string='a'.repeat(len);
4038
if(encoding){
4139
bench.start();
42-
for(i=0;i<n;++i){
40+
for(leti=0;i<n;++i){
4341
buf.write(string,0,buf.length,encoding);
4442
}
4543
bench.end(n);
4644
}else{
4745
bench.start();
48-
for(i=0;i<n;++i){
46+
for(leti=0;i<n;++i){
4947
buf.write(string,0,buf.length);
5048
}
5149
bench.end(n);
@@ -55,13 +53,13 @@ function main({len, n, encoding, args }){
5553
string='a'.repeat(len);
5654
if(encoding){
5755
bench.start();
58-
for(i=0;i<n;++i){
56+
for(leti=0;i<n;++i){
5957
buf.write(string,encoding);
6058
}
6159
bench.end(n);
6260
}else{
6361
bench.start();
64-
for(i=0;i<n;++i){
62+
for(leti=0;i<n;++i){
6563
buf.write(string);
6664
}
6765
bench.end(n);

0 commit comments

Comments
(0)