Skip to content

benchmark: use let/const instead of var in buffers#30945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dnlup wants to merge 1 commit into from
Closed

benchmark: use let/const instead of var in buffers #30945

dnlup wants to merge 1 commit into from
+26 −31

Conversation

@dnlup
Copy link
Contributor

@dnlupdnlup commented Dec 13, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. labels Dec 13, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Dec 15, 2019

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4109/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2019
@targos
Copy link
Member

targos commented Dec 16, 2019

Landed in bfce726

@targostargos closed this Dec 16, 2019
targos pushed a commit that referenced this pull request Dec 16, 2019
@dnlup@targos
benchmark: use let/const instead of var in buffers
bfce726
PR-URL: #30945 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@dnlup@MylesBorins
benchmark: use let/const instead of var in buffers
b6ddbc1
PR-URL: #30945 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 17, 2019
Merged
@dnlupdnlup deleted the benchmarks_buffers branch January 10, 2020 13:39
targos pushed a commit that referenced this pull request Jan 14, 2020
@dnlup@targos
benchmark: use let/const instead of var in buffers
47b5367
PR-URL: #30945 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@dnlup@BethGriggs
benchmark: use let/const instead of var in buffers
baabf3e
PR-URL: #30945 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeARBridgeARBridgeAR approved these changes

@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.bufferIssues and PRs related to the buffer subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dnlup@BridgeAR@targos@trivikr@nodejs-github-bot