Proxy Error wrapped Promise in debug mode

[sky-train]

• Version: 7.3.0
• Platform: Windows 64-bit
• Subsystem:

nodejs/help#417

if there is a breakpoint, and script execution in debug mode results in an error:

Fatal error in runtime\runtime-debug.cc, line 1423
Check failed: args[0]->IsJSObject().
==== C stack trace ===============================
v8::Testing::DeoptimizeAll [0x00007FF63641E116+1835382]
v8::Testing::DeoptimizeAll [0x00007FF6365CAD2D+3591565]
(No symbol) [0x000003442F4063AB]

script is run on WebStorm, VS2015

error occurs in the transition from let proxy = createProxy(); to resolve(proxy);

function createProxy(){
 let handler ={
 get(target,key,context){
 return Reflect.get(target,key,context);
 }
 }
 ,data ={a:1};
 return new Proxy(data,handler);
}

function load(){
 return new Promise(function (resolve,reject){
 let proxy = createProxy();
 resolve(proxy);
 });
}

load().then(function (proxy){
 console.log(proxy.a);
});

[mscdex]

/cc @nodejs/v8

[bnoordhuis]

It's the result of a %DebugGetPrototype(this.value_) call in deps/v8/src/debug/mirrors.js with a value that isn't an object or array. I'm not able to reproduce locally but I expect that is because the built-in debugger doesn't hit that particular code path.

Does node --inspect script.js work for you?

[sky-train]

Does node --inspect script.js work for you?

yes it work.

[bnoordhuis]

@SklyarovYura Can you try the fix from #10409?

[sky-train]

Can you try the fix from #10409?

Thanks it works

[TimothyGu]

BTW, #8224 describes an issue of the same underlying cause as this one.

[targos]

Fixed in #10409