parallel/test-benchmark-misc failure on v8.x-staging

[gibfahn]

• Version: 8.x

This test is failing on v8.x-staging. The ubuntu1604_sharedlibs_withoutintl_x64 job was recently added, see nodejs/build#1182.

Example failure: https://ci.nodejs.org/job/node-test-commit-linux-containered/2952/nodes=ubuntu1604_sharedlibs_withoutintl_x64/

Error

not ok 156 parallel/test-benchmark-misc
 ---
 duration_ms: 1.430
 severity: fail
 stack: |-

 misc/console.js
 misc/console.js n=1 concat=0 method="": 508.4230445795494

 misc/freelist.js
 misc/freelist.js n=1: 1,203.6576749426156

 misc/function_call

 misc/object-property-bench.js
 misc/object-property-bench.js millions=0.000001 method="": 0.005865102639296188

 misc/punycode.js
 misc/function_call.js Binding failed to load
 /home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_withoutintl_x64/benchmark/misc/punycode.js:4
 const icu = process.binding('icu');
 ^

 Error: No such module: icu
 at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_withoutintl_x64/benchmark/misc/punycode.js:4:21)
 at Module._compile (module.js:652:30)
 at Object.Module._extensions..js (module.js:663:10)
 at Module.load (module.js:565:32)
 at tryModuleLoad (module.js:505:12)
 at Function.Module._load (module.js:497:3)
 at Function.Module.runMain (module.js:693:10)
 at startup (bootstrap_node.js:188:16)
 at bootstrap_node.js:609:3
 assert.js:42
 throw new errors.AssertionError({
 ^

 AssertionError [ERR_ASSERTION]: 1 === 0
 at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_withoutintl_x64/test/common/benchmark.js:25:12)
 at emitTwo (events.js:126:13)
 at ChildProcess.emit (events.js:214:7)
 at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
 ...

I assume the test just needs to be skipped if without intl, but there is probably already a backport that fixes it.

[yhwang]

need to backport this #16251 to solve the issue. I saw the backport-requested-v8.x label in that PR. basically, the ubuntu1604_sharedlibs_withoutintl_x64 will keep hitting this issue until that PR is backported.

[MylesBorins]

@yhwang that PR seems to touch code that was only added in 9.x. Not 100% it is the exact same problem

[MylesBorins]

ping @srl295

[yhwang]

@MylesBorins #16251 modifies benchmark/misc/punycode.js and that fixes the failure of parallel/test-benchmark-misc.

at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_withoutintl_x64/benchmark/misc/punycode.js:4:21)

[apapirovski]

Fixed in #20478

[srl295]

that PR seems to touch code that was only added in 9.x. Not 100% it is the exact same problem

without intl means the icu module won't be available, so it is the same issue

[srl295]

looks like it was fixed by a backport after all, anyway I did not see this at all