Attempting to convert old non-existing history file fails

[toddself]

Just upgraded to 3.0.0 from 0.10.28 on linux.

↳ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 14.04.3 LTS
Release: 14.04
Codename: trusty

trying to launch the repl results in:

todd@scripto-local 18:14:50 /home/.../src/deploybot:couch
↳ node
>
Converting old JSON repl history to line-separated history.
The new repl history file can be found at /home/todd/.node_repl_history.
> node.js:129
 throw err;
 ^

Error: Could not parse history data in /home/todd/.node-history.
 at onread (internal/repl.js:126:13)
 at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:380:3)
todd@scripto-local 18:16:22 /home/.../src/deploybot:couch
↳ node --version
v3.0.0

This seems to be due to the fact that i have NODE_REPL_HISTORY_FILE set, but there is no actual file present:

todd@scripto-local 18:16:24 /home/.../src/deploybot:couch
↳ echo $NODE_REPL_HISTORY_FILE
/home/todd/.node-history
todd@scripto-local 18:16:48 /home/.../src/deploybot:couch
↳ cat $NODE_REPL_HISTORY_FILE
cat: /home/todd/.node-history: No such file or directory

[toddself]

I have a potential fix for this -- am verifying it and writing tests

[thefourtheye]

ping @Fishrock123

[toddself]

I'm not sure if it needs more tests than that? (Or if that's a valid test?)

The resulting binary works correctly for me.

[Fishrock123]

Isn't this the expected behavior, that option would have done that before?

Edit: ah I understand, before it would have made a file.

[Fishrock123]

Fixed by 3849750 :)