flaky test parallel/test-worker-eventlooputil

[gireeshpunathil]

fail: https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd11-x64/36185/console
pass: https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd11-x64/36184/console

11:49:30 not ok 2731 parallel/test-worker-eventlooputil
11:49:30 ---
11:49:30 duration_ms: 0.855
11:49:30 severity: fail
11:49:30 exitcode: 1
11:49:30 stack: |-
11:49:30 node:events:304
11:49:30 throw er; // Unhandled 'error' event
11:49:30 ^
11:49:30 
11:49:30 AssertionError [ERR_ASSERTION]: 266.02071380615234 <= 380.5895614624024
11:49:30 at MessagePort.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-worker-eventlooputil.js:107:12)
11:49:30 at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:355:41)
11:49:30 at MessagePort.exports.emitMessage (node:internal/per_context/messageport:18:26)
11:49:30 Emitted 'error' event on process instance at:
11:49:30 at emitUnhandledRejectionOrErr (node:internal/event_target:544:11)
11:49:30 at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:359:9)
11:49:30 at MessagePort.exports.emitMessage (node:internal/per_context/messageport:18:26){
11:49:30 generatedMessage: false,
11:49:30 code: 'ERR_ASSERTION',
11:49:30 actual: false,
11:49:30 expected: true,
11:49:30 operator: '=='
11:49:30 }
11:49:30 ...

/cc @nodejs/workers @trevnorris

[gireeshpunathil]

I am yet to fully understand the logic at the assertion site, just wondering in:

node/test/parallel/test-worker-eventlooputil.js

Line 107 in 3df5afb

assert.ok(idleActive(wElu) > idleActive(w2),

is wElu actually w? I ask this because w is unused in the entire section:

node/test/parallel/test-worker-eventlooputil.js

Lines 99 to 112 in 3df5afb

	function checkWorkerActive() {
	const w = workerELU();
	metricsCh.port2.postMessage({ cmd: 'spin', dur: 50 });
	metricsCh.port2.once('message', (wElu) => {
	const w2 = workerELU(w);
	assert.ok(w2.active >= 50, `${w2.active} < 50`);
	assert.ok(idleActive(wElu) > idleActive(w2),
	`${idleActive(wElu)} <= ${idleActive(w2)}`);
	metricsCh.port2.postMessage({ cmd: 'close' });
	});
	}

[Trott]

This test is failing a lot in CI.

https://ci.nodejs.org/job/node-test-commit-freebsd/36245/nodes=freebsd11-x64/console on test-digitalocean-freebsd11-x64-2

00:19:11 not ok 2731 parallel/test-worker-eventlooputil
00:19:11 ---
00:19:11 duration_ms: 0.777
00:19:11 severity: fail
00:19:11 exitcode: 1
00:19:11 stack: |-
00:19:11 node:events:304
00:19:11 throw er; // Unhandled 'error' event
00:19:11 ^
00:19:11 
00:19:11 AssertionError [ERR_ASSERTION]: 173.09381866455078 <= 272.75743865966797
00:19:11 at MessagePort.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-worker-eventlooputil.js:107:12)
00:19:11 at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:367:41)
00:19:11 at MessagePort.exports.emitMessage (node:internal/per_context/messageport:18:26)
00:19:11 Emitted 'error' event on process instance at:
00:19:11 at emitUnhandledRejectionOrErr (node:internal/event_target:558:11)
00:19:11 at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:371:9)
00:19:11 at MessagePort.exports.emitMessage (node:internal/per_context/messageport:18:26){
00:19:11 generatedMessage: false,
00:19:11 code: 'ERR_ASSERTION',
00:19:11 actual: false,
00:19:11 expected: true,
00:19:11 operator: '=='
00:19:11 }
00:19:11 ...

[gireeshpunathil]

looks like, at least the failing site is consistent.