investigate flaky sequential/test-fs-watch

[Trott]

• Test: sequential/test-fs-watch
• Platform: osx1015
• Console Output:

01:28:10 not ok 3107 sequential/test-fs-watch
01:28:10 ---
01:28:10 duration_ms: 120.86
01:28:10 severity: fail
01:28:10 exitcode: -15
01:28:10 stack: |-
01:28:10 timeout
01:28:10 ...

• Build Links:
  https://ci.nodejs.org/job/node-test-commit-osx/37546/nodes=osx1015/console

test-orka-macos10.15-x64-2

[Trott]

Stress test: https://ci.nodejs.org/job/node-stress-single-test/205/

[Trott]

I'm pretty sure this is the old "macos returns the watcher before it's actually watching the file system" issue. My solution in the past has been to have the file modified every few seconds in the test instead of just once.

[Trott]

Stress test: https://ci.nodejs.org/job/node-stress-single-test/205/

Failed 2 times in 1000 runs on osx15. I'm able to replicate this locally. It failed 4 times in 1000 runs.