test-fs-read-type fails on IBM i

[Trott]

I think it fails every time now that 72b678a was merged a day or two ago. Since IBM i only runs in the nightly CI job, this issue wasn't apparent during pull request reviews.

Wha't's the right thing to do here? Leave it for now and someone on @nodejs/platform-ibmii will take a look? Add this to the list of skipped tests on IBM i in parallel.status? Both? Something else?

https://ci.nodejs.org/job/node-test-commit-ibmi/223

not ok 844 parallel/test-fs-read-type
 ---
 duration_ms: 1.622
 severity: fail
 exitcode: 1
 stack: |-
 /home/iojs/build/workspace/node-test-commit-ibmi/nodes/ibmi72-ppc64/test/parallel/test-fs-read-type.js:238
 if (err.code !== 'EFBIG') throw err;
 ^
 
 Error: UNKNOWN: unknown error, read
 at Object.readSync (node:fs:634:3)
 at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-ibmi/nodes/ibmi72-ppc64/test/parallel/test-fs-read-type.js:229:6)
 at Module._compile (node:internal/modules/cjs/loader:1108:14)
 at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10)
 at Module.load (node:internal/modules/cjs/loader:973:32)
 at Function.Module._load (node:internal/modules/cjs/loader:813:14)
 at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
 at node:internal/main/run_main_module:17:47{
 errno: -127,
 syscall: 'read',
 code: 'UNKNOWN'
 }
 ...

@nodejs/platform-ibmi @RaisinTen

[ThePrez]

cc @nodejs/platform-ibmi
I vote leave this one for know, and assign to @dmabupt and me

[Trott]

I vote leave this one for know, and assign to @dmabupt and me

Thanks. I assigned to you. It won't let me assign to @dmabupt as well because they are not a member of the org. Should they be added to @nodejs/platform-ibmi? Or is the omission there intentional?

[richardlau]

I vote leave this one for know, and assign to @dmabupt and me

Thanks. I assigned to you. It won't let me assign to @dmabupt as well because they are not a member of the org. Should they be added to @nodejs/platform-ibmi? Or is the omission there intentional?

They were invited to join the team according to nodejs/admin#490 (comment)

[RaisinTen]

I'm sorry this happened. Perhaps adding a check for err.code !== 'UNKNOWN' would do the trick:

node/test/parallel/test-fs-read-type.js

Line 238 in 1772ae7

if (err.code !== 'EFBIG') throw err;

- if (err.code !== 'EFBIG') throw err;
+ if (err.code !== 'EFBIG' && err.code !== 'UNKNOWN') throw err;

[richardlau]

I'm sorry this happened. Perhaps adding a check for err.code !== 'UNKNOWN' would do the trick:

node/test/parallel/test-fs-read-type.js

Line 238 in 1772ae7

if (err.code !== 'EFBIG') throw err;

- if (err.code !== 'EFBIG') throw err;
+ if (err.code !== 'EFBIG' && err.code !== 'UNKNOWN') throw err;

I'd rather see if the UNKNOWN could be mapped to something more informative in the Node.js/libuv layer. I think errno: -127 is EOVERFLOW:

-bash-4.4$ grep 127 /usr/include/errno.h
#define EOVERFLOW 127 /* value too large to be stored in data type */
-bash-4.4$

[ThePrez]

I vote leave this one for know, and assign to @dmabupt and me

Thanks. I assigned to you. It won't let me assign to @dmabupt as well because they are not a member of the org. Should they be added to @nodejs/platform-ibmi? Or is the omission there intentional?

@dmabupt should definitely be added to the @nodejs/platform-ibmi team. @dmabupt, please check to see if you have a pending invite still, or maybe you need to be re-invited.

[RaisinTen]

Sorry again, I misclicked.

[mhdawson]

Invited @dmabupt to the team.