Unable to make doc-only

[mcollina]

• Version: master
• Platform: linux
• Subsystem: doc

What steps will reproduce the bug?

make doc-only

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

docs are build

What do you see instead?

if [ -x /home/matteo/repositories/node/./node ] && [ -e /home/matteo/repositories/node/./node ]; then /home/matteo/repositories/node/./node tools/doc/generate.js --node-version=v17.0.0 --apilinks=out/doc/apilinks.json doc/api/debugger.md --output-directory=out/doc/api --versions-file=out/previous-doc-versions.json; elif [ -x `command -v node` ] && [ -e `command -v node` ] && [ `command -v node` ]; then `command -v node` tools/doc/generate.js --node-version=v17.0.0 --apilinks=out/doc/apilinks.json doc/api/debugger.md --output-directory=out/doc/api --versions-file=out/previous-doc-versions.json; else echo "No available node, cannot run \"node tools/doc/generate.js --node-version=v17.0.0 --apilinks=out/doc/apilinks.json doc/api/debugger.md --output-directory=out/doc/api --versions-file=out/previous-doc-versions.json\""; exit 1; fi;
/home/matteo/repositories/node/tools/doc/node_modules/unified/index.js:469
 throw new Error(
 ^

Error: `processSync` finished async. Use `process` instead
 at assertDone (/home/matteo/repositories/node/tools/doc/node_modules/unified/index.js:469:11)
 at Function.processSync (/home/matteo/repositories/node/tools/doc/node_modules/unified/index.js:401:5)
 at Object.<anonymous> (/home/matteo/repositories/node/tools/doc/html.js:64:4)
 at Module._compile (node:internal/modules/cjs/loader:1109:14)
 at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)
 at Module.load (node:internal/modules/cjs/loader:989:32)
 at Function.Module._load (node:internal/modules/cjs/loader:829:14)
 at Module.require (node:internal/modules/cjs/loader:1013:19)
 at require (node:internal/modules/cjs/helpers:93:18)
 at Object.<anonymous> (/home/matteo/repositories/node/tools/doc/generate.js:35:14)
make[1]: *** [Makefile:745: out/doc/api/debugger.html] Error 1
make: *** [Makefile:698: doc-only] Error 2

Additional information

There is likely some old cruft in my checkout that I can't seem to clean up make clean; make distclean don't do the trick.

[Trott]

I can try to take a look at this later, but my immediate thought is: Does rm -rf tools/doc/node_modules fix it?

[mcollina]

That did not work :/. For some reason I can't comprehend

node/tools/doc/html.js

Line 64 in 78af363

.processSync(gtocMD).toString();

would like to be async.

[Trott]

That means that gtocMD() is supposed to be

That did not work :/. For some reason I can't comprehend

node/tools/doc/html.js

Line 64 in 78af363

.processSync(gtocMD).toString();

would like to be async.

Yeah, that is odd. Is your git HEAD 78af363 or something else? Does it start working if you first run rm -rf out/doc/api/debugger.* or even rm -rf out/doc?

[mcollina]

Yes, I'm at 78af363

[Trott]

Maybe something weird in out/doc/api/debugger.md? Remove out/doc and try again? Or did you do that already?

[mcollina]

I removed everything several times. Maybe there is some residual in a gitignored dot-folder?

[targos]

Last resort: git clean -fdx will remove everything that's either not tracked or gitignored

[mcollina]

Unfortunately even that or creating a fresh clone did not do the trick.

I also tried looking at the various steps and I can't seem to find where that becomes async.

[targos]

@mcollina can you try with #38966 ?

[mcollina]

@mcollina can you try with #38966 ?

That does the trick.