src: v8 deprecations in 4.9 branch

[ChALkeR]

Extracted from Mark all APIs without callers in Blink as deprecated, compared with the current Node.js master:

• Trivial one-liners, fixed by ChALkeR@45e0ec2:

 TerminateExecution
src/node_watchdog.cc

 CancelTerminateExecution
src/node_contextify.cc

• Notable ones:

 ForceSet
src/node_contextify.cc
src/node_internals.h
src/node.cc
src/node.h

 SetWeak
src/node_contextify.cc
src/node_object_wrap.h
src/node_buffer.cc

• Commented out code:

 GetPropertyAttributes
src/node_contextify.cc

• Maybe-related:

 Compile
src/node_contextify.cc
src/node.cc

 CompileUnbound
src/node_contextify.cc

 Delete
src/node_contextify.cc
src/node.cc
src/stream_base.cc

 GetEndColumn
src/node.cc

 GetRealNamedProperty
src/node_contextify.cc

 GetRealNamedPropertyAttributes
src/node_contextify.cc

 Has
src/node.cc
src/stream_base.cc
src/node_os.cc

 HasOwnProperty
src/node_contextify.cc

 NewFromOneByte
src/util.h
src/util-inl.h
src/env-inl.h

 NewInstance
src/pipe_wrap.cc
src/node_contextify.cc
src/debug-agent.cc
src/node.cc
src/env-inl.h
src/node_file.cc
src/udp_wrap.cc
src/tls_wrap.cc
src/tcp_wrap.cc

 SetAccessor
src/node.cc
src/udp_wrap.cc
src/stream_base-inl.h
src/node_crypto.cc

 SetPrototype
src/node_buffer.cc

May contain false positives (the check is not absolute) and false negatives (I am basing upon just one v8 deprecation commit).

[ChALkeR]

Cross-linking with #4722

[evanlucas]

@ChALkeR looks like #4722 has landed. Any reason to keep this one open?

[targos]

#4722 did not replace all of deprecated APIs that we are using.

@ChALkeR could you transform your OP in a task list ?

[ChALkeR]

@targos Done.

Sub-tasks (note that this may contain false positives):

Trivial one-liners, fixed by ChALkeR@45e0ec2

• TerminateExecution — src/node_watchdog.cc
• CancelTerminateExecution — src/node_contextify.cc

Notable ones

• ForceSet — src/node_contextify.cc
• ForceSet — src/node_internals.h
• ForceSet — src/node.cc
• ForceSet — src/node.h
• SetWeak — src/node_contextify.cc
• SetWeak — src/node_object_wrap.h
• SetWeak — src/node_buffer.cc

Commented out code

• GetPropertyAttributes — src/node_contextify.cc

Maybe-related

• Compile — src/node_contextify.cc
• Compile — src/node.cc
• CompileUnbound — src/node_contextify.cc
• Delete — src/node_contextify.cc
• Delete — src/node.cc
• Delete — src/stream_base.cc
• GetEndColumn — src/node.cc
• GetRealNamedProperty — src/node_contextify.cc
• GetRealNamedPropertyAttributes — src/node_contextify.cc
• Has — src/node.cc
• Has — src/stream_base.cc
• Has — src/node_os.cc
• HasOwnProperty — src/node_contextify.cc
• NewExternal — src/string_bytes.cc
• NewFromOneByte — src/util.h
• NewFromOneByte — src/util-inl.h
• NewFromOneByte — src/env-inl.h
• NewInstance — src/pipe_wrap.cc
• NewInstance — src/node_contextify.cc
• NewInstance — src/debug-agent.cc
• NewInstance — src/node.cc
• NewInstance — src/env-inl.h
• NewInstance — src/node_file.cc
• NewInstance — src/udp_wrap.cc
• NewInstance — src/tls_wrap.cc
• NewInstance — src/tcp_wrap.cc
• SetAccessor — src/node.cc
• SetAccessor — src/udp_wrap.cc
• SetAccessor — src/stream_base-inl.h
• SetAccessor — src/node_crypto.cc
• SetPrototype — src/node_buffer.cc

[ofrobots]

I didn't address the GetPropertyAttribute inside commented out code, but I think all the deprecations listed here have been addressed.

[ChALkeR]

@ofrobots Thanks!

I'm going to close this, I don't think that commented out code should keep this open.