process.versions.zlib does not include the commit hash

[panva]

Despite upgrade to the bundled zlib library in #50085 the process.versions.zlib output remains the same.

node -p 'process.versions.zlib'
1.2.13.1-motley
node -v
v18.18.1

./node -p 'process.versions.zlib'
1.2.13.1-motley
./node -v
v21.0.0-pre

The expected output of process.versions.zlib would be e.g. 1.2.13.1-motley-f5fd0ad, that is including the commit hash from upstream.

[MrJithil]

Seems like ZLIB_VERSION not updated in the zlib.h header file. I can see same version info after running the tools/dep_updaters/update-zlib.sh

[MrJithil]

The version info we are using https://chromium.googlesource.com/chromium/src/third_party/zlib.git/+/refs/heads/main/zlib.h#40 from here. Which is 1.2.13.1-motley

So, seems its working as designed.

[panva]

It's clearly insufficient given the updates don't change this constant. It should include the current hash.

[MrJithil]

Okay. Could you please suggest which variable should map here? Or do we need to take the latest commit hash shorthand?

[panva]

@MrJithil

node/tools/dep_updaters/update-zlib.sh

Line 82 in ed49722

NEW_VERSION="$VERSION_NUMBER-$LATEST_COMMIT"

[MrJithil]

Got it.
Please suggest the approach.

To accomodate the commit shorthand, we need to create a new header file inside the deps/zlib with a new definition, ZLIB_VERSION or some suitable names.

Then inside the src/node_metadata.cc , we can import the new definition.

Is this is fine?