code and learn pr change#10004
Closed
code and learn pr change #10004
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
mscdex commented Dec 1, 2016
Please see the commit message guidelines here. |
Member
imyller commented Dec 1, 2016
@CodeTheInternet May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
imyller added the code-and-learn 
ContributorAuthor
CodeTheInternet commented Dec 1, 2016
Member
imyller commented Dec 1, 2016
@CodeTheInternet Looks great! Thank you 👍 |
cjihrig approved these changes Dec 3, 2016
Member
mhdawson commented Dec 5, 2016
Member
mhdawson commented Dec 5, 2016
CI ok except for ARM failure that looks like: #10073 Should be good to go. Will land. |
Member
mhdawson commented Dec 5, 2016
@CodeTheInternet for the next time, you had an extra dot in the commit message. You should either have the header line, followed by a blank line, followed by a description of the change OR just the header line. I'll remove the line with the dot while landing. |
Member
mhdawson commented Dec 5, 2016
Landed as 7b4c598 |
mhdawson pushed a commit that referenced this pull request Dec 5, 2016
PR-URL: #10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
PR-URL: #10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
PR-URL: nodejs#10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
PR-URL: nodejs#10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
PR-URL: #10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
PR-URL: #10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
PR-URL: #10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strictEqual change for parallel test