test: fix test-child-process-stdin.js#10022
Uh oh!
There was an error while loading. Please reload this page.
Conversation
37:5 error please use assert.strictEqual() instead of assert.equal() 39:5 error please use assert.strictEqual() instead of assert.equal()
imyller added code-and-learn 
| cat.on('exit',common.mustCall(function(status){ | ||
| assert.strictEqual(0,status); | ||
| })); | ||
There was a problem hiding this comment.
There are two uses of assert.ok() in this file that could be greatly improved by changing to assert.strictEqual().
Trott commented Dec 22, 2016
Ping @sriluvan: Can you update this per the comment from @cjihrig? The values passed to |
navulirs commented Dec 22, 2016
Hi. I will get it in by tomorrow. Sorry for the delay again. Thanks. |
navulirs commented Dec 22, 2016
I have fixed the issue and created the pull request. Again I'm sorry as I couldn't attend the request in time. This is first time I'm getting change in outside the group work held in Austin. I'm hoping I followed the guidelines properly. Please let know if any thing not done correctly. I'm hoping this delay won't repeat. Thanks. |
sam-github left a comment
sam-github left a comment There was a problem hiding this comment.
Commit message is
37:5 error please use assert.strictEqual() instead of assert.equal() 39:5 error please use assert.strictEqual() instead of assert.equal() That isn't useful, please put in a human readable description.
Use assert.strictEqual() instead of assert.equal().
Would be good.
navulirs commented Dec 23, 2016
The message I added was "assert.ok to assert.strictEqual" - as per the change requested in this thread. - not the message in your email. I opened the commit message in amend node to check what is the comments area but I don't see the message in your comment. Can you direct me. Thanks. |
navulirs commented Dec 23, 2016
The pull request with the suggested changes are in now. I'm not sure if this updated the original pull request or created new. Let me know if it is not update to original PR. Just want to know if I did the right steps. |
Trott commented Dec 24, 2016
Closing in favor of #10420 |
7 participants
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
37:5 error please use assert.strictEqual() instead of assert.equal()
39:5 error please use assert.strictEqual() instead of assert.equal()