test: check for error on invalid signal#10026
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
imyller added code-and-learn 
bnoordhuis approved these changes Dec 1, 2016
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/5072/ (currently queued)
Contributor
There was a problem hiding this comment.
Could you put a space before this comment, e.g. // Test...? :D
Asserts that an error should be thrown when an invalid signal is passed to process.kill
mattcphillipsforce-pushed the test/process.kill_signal_error branch from a82c7e2 to 5fdea9dCompare
jasnell reviewed Dec 5, 2016
| // Test that kill throws an error for invalid signal | ||
| assert.throws(function(){process.kill(1,'test');},Error); |
Member
There was a problem hiding this comment.
This is ok but passing a regexp as the second argument would be better.
assert.throws(()=>{process.kill(1,'test');},/^Error:Unknownsignal:test$/);
Fishrock123 approved these changes Dec 6, 2016
Contributor
Fishrock123 left a comment
Fishrock123 left a comment There was a problem hiding this comment.
LGTM with @jasnell's suggestion.
cjihrig approved these changes Dec 6, 2016
Member
Trott commented Dec 8, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 9, 2016
Asserts that an error should be thrown when an invalid signal is passed to process.kill(). PR-URL: nodejs#10026 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
Trott commented Dec 9, 2016
Landed in 6aacef7. I agree with the nit about using a RegExp rather than a constructor for |
Fishrock123 pushed a commit that referenced this pull request Dec 13, 2016
Asserts that an error should be thrown when an invalid signal is passed to process.kill(). PR-URL: #10026 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 16, 2017
Asserts that an error should be thrown when an invalid signal is passed to process.kill(). PR-URL: #10026 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2017
Asserts that an error should be thrown when an invalid signal is passed to process.kill(). PR-URL: #10026 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Asserts that an error should be thrown when an invalid signal is passed to process.kill(). PR-URL: #10026 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Asserts that an error should be thrown when an invalid signal is passed to process.kill(). PR-URL: #10026 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Asserts that an error should be thrown when an invalid signal is passed to process.kill(). PR-URL: #10026 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
Asserts that an error should be thrown when an invalid signal is passed to process.kill(). PR-URL: #10026 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Asserts that an error should be thrown when an invalid signal is passed to process.kill