test: change the equal() by strictEqual()#10027
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Improved test by using strictEqual instead of equal
imyller added the code-and-learn 
mscdex added the events 
cjihrig approved these changes Dec 5, 2016
jasnell approved these changes Dec 5, 2016
evanlucas approved these changes Dec 7, 2016
Contributor
evanlucas left a comment
evanlucas left a comment There was a problem hiding this comment.
LGTM
CI: https://ci.nodejs.org/job/node-test-pull-request/5288/
Thanks for the contribution! I'll land after CI run finishes.
Contributor
evanlucas commented Dec 7, 2016
Landed in ee8848d with an amended commit message. Thanks for the contribution and for participating in the Code and Learn session! |
evanlucas pushed a commit that referenced this pull request Dec 7, 2016
Improved test by using strictEqual instead of equal. PR-URL: #10027 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
addaleax pushed a commit that referenced this pull request Dec 8, 2016
Improved test by using strictEqual instead of equal. PR-URL: #10027 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Improved test by using strictEqual instead of equal. PR-URL: nodejs#10027 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Improved test by using strictEqual instead of equal. PR-URL: #10027 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Improved test by using strictEqual instead of equal. PR-URL: #10027 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Improved test by using strictEqual instead of equal. PR-URL: #10027 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Improved test by using strictEqual instead of equal