url, test: add inspect to TupleOrigin#10039
Closed
+46 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This adds a simple inspect function the the TupleOrigin class.
This adds tests for the newly added inspect function in the TupleOrigin class.
nodejs-github-bot added the url 
captainsafia changed the title 
imyller added the code-and-learn 
Trott added the semver-minor 
Member
Trott commented Dec 2, 2016
addaleax approved these changes Dec 2, 2016
lib/internal/url.js Outdated
| } | ||
| inspect(){ | ||
| return`TupleOrigin{ |
Member
There was a problem hiding this comment.
I think we have spaces before the { in most cases here?
Member
jasnell commented Dec 2, 2016 via email
Lgtm …On Fri, Dec 2, 2016 at 11:19 AM Colin Ihrig ***@***.***> wrote: ***@***.**** approved this pull request. LGTM with @addaleax <https://github.com/addaleax>'s nit addressed and a CI run. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10039 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa2ecmm-yrL9WiUggst-DNXQrt8VTw_ks5rEFMMgaJpZM4LBsld> . |
ContributorAuthor
captainsafia commented Dec 2, 2016
Nit addressed. |
gibfahn approved these changes Dec 2, 2016
Member
gibfahn commented Dec 2, 2016
Member
addaleax commented Dec 2, 2016
@captainsafia Looks like you need to update the test files too? :) |
Member
addaleax commented Dec 2, 2016
Thanks for being so quick to update! Here’s a new CI: https://ci.nodejs.org/job/node-test-commit/6348/ |
ContributorAuthor
captainsafia commented Dec 2, 2016
@addaleax: Whoops. Excuse my merge-eager fingers. Fixed now. 😊 |
Member
addaleax commented Dec 5, 2016
Landed in 8831732, thanks for the contribution! |
addaleax pushed a commit that referenced this pull request Dec 5, 2016
This adds a simple inspect function the the TupleOrigin class. This adds tests for the newly added inspect function in the TupleOrigin class. PR-URL: #10039 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Member
jasnell commented Dec 5, 2016
Thank you for this @captainsafia ... this one has been on my list of todo's for remaining items on the new |
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
This adds a simple inspect function the the TupleOrigin class. This adds tests for the newly added inspect function in the TupleOrigin class. PR-URL: nodejs#10039 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 15, 2016
This adds a simple inspect function the the TupleOrigin class. This adds tests for the newly added inspect function in the TupleOrigin class. PR-URL: #10039 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Merged
italoacasas pushed a commit that referenced this pull request Dec 15, 2016
Notable changes SEMVER-MINOR - url: - add inspect function to TupleOrigin (Safia Abdalla) #10039 - crypto: - allow adding extra certs to well-known CAs (Sam Roberts) #9139 SEMVER-PATCH - buffer: - fix single-character string filling (Anna Henningsen) #9837 - handle UCS2 .fill() properly on BE (Anna Henningsen) #9837 - url: - including base argument in originFor (joyeecheung) #10021 - improve URLSearchParams spec compliance (Timothy Gu) #9484 - http: - remove stale timeout listeners (Karl Böhlmark) #9440 - build: - fix node_g target (Daniel Bevenius) #10153 - fs: - remove unused argument from copyObject() (Ethan Arrowood) #10041 - timers: - fix handling of cleared immediates (hveldstra) #9759 PR-URL: #10277
italoacasas pushed a commit that referenced this pull request Dec 17, 2016
Notable changes: * **crypto**: - Allow adding extra certificates to well-known CAs. (Sam Roberts) [#9139](#9139) * **buffer**: - Fix single-character string filling. (Anna Henningsen) [#9837](#9837) - Handle UCS2 `.fill()` properly on BE. (Anna Henningsen) [#9837](#9837) * **url**: - Add inspect function to TupleOrigin. (Safia Abdalla) [#10039](#10039) - Including base argument in originFor. (joyeecheung) [#10021](#10021) - Improve URLSearchParams spec compliance. (Timothy Gu) [#9484](#9484) * **http**: - Remove stale timeout listeners. (Karl Böhlmark) [#9440](#9440) * **build**: - Fix node_g target. (Daniel Bevenius) [#10153](#10153) * **fs**: - Remove unused argument from copyObject(). (EthanArrowood) [#10041](#10041) * **timers**: - Fix handling of cleared immediates. (hveldstra) [#9759](#9759) * **src**: - Add wrapper for process.emitWarning(). (SamRoberts) [#9139](#9139) - Fix string format mistake for 32 bit node.(Alex Newman) [#10082](#10082)
joyeecheung added the whatwg-url Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
url, test
Description of change
This PR adds code and tests for an inspect function on the
TupleOriginobject.