Improvements to test-buffer-slice from NINA code & learn#10048
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits December 1, 2016 11:42
- change implicit string equal() compares to strictEqual compares of buffer output (the slice output default) - explicitly create buffers from utf8 inputs for the compare -
- change implicit string equal() compares to strictEqual compares of buffer output (the slice output default) - explicitly create buffers from utf8 inputs for the compare
imyller added code-and-learn 
Member
Trott commented Dec 5, 2016
jasnell approved these changes Dec 5, 2016
| assert.strictEqual(0,Buffer.from('hello').slice(0,0).length); | ||
| assert.strictEqual(0,Buffer('hello').slice(0,0).length); | ||
| assert.strictEqual(0,Buffer.from('hello','utf8').slice(0,0).length); | ||
| assert.strictEqual(0,Buffer('hello','utf8').slice(0,0).length); |
Member
There was a problem hiding this comment.
nit: adding 'utf8' to these is unnecessary since that is the default already.
jasnell pushed a commit that referenced this pull request Dec 5, 2016
* change implicit string equal() compares to strictEqual compares of buffer output (the slice output default) * explicitly create buffers from utf8 inputs for the compare PR-URL: #10048 Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Dec 5, 2016
Landedin 02a4c08. thank you for the PR and for participating in the code-and-learn! |
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
* change implicit string equal() compares to strictEqual compares of buffer output (the slice output default) * explicitly create buffers from utf8 inputs for the compare PR-URL: #10048 Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
* change implicit string equal() compares to strictEqual compares of buffer output (the slice output default) * explicitly create buffers from utf8 inputs for the compare PR-URL: nodejs#10048 Reviewed-By: James M Snell <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
* change implicit string equal() compares to strictEqual compares of buffer output (the slice output default) * explicitly create buffers from utf8 inputs for the compare PR-URL: nodejs#10048 Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
* change implicit string equal() compares to strictEqual compares of buffer output (the slice output default) * explicitly create buffers from utf8 inputs for the compare PR-URL: #10048 Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change