Skip to content

Conversation

@Exlipse7
Copy link

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@Exlipse7Exlipse7force-pushed the codeandlearnexlipse7 branch from 2a5f3f9 to 55999fdCompareDecember 1, 2016 18:29
@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@addaleax
Copy link
Member

@mscdexmscdex added the process Issues and PRs related to the process subsystem. label Dec 3, 2016
@Trott
Copy link
Member

Trott commented Dec 5, 2016

Landed in 2b293b7.
Thanks for the contribution! 🎉

@TrottTrott closed this Dec 5, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2016
Switch assert.equal to assert.strictEqual. PR-URL: nodejs#10057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
Switch assert.equal to assert.strictEqual. PR-URL: #10057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@Fishrock123Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
@Exlipse7
Copy link
Author

Awesome, thanks to the code and learn team! You all made it super easy to get started.

addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Switch assert.equal to assert.strictEqual. PR-URL: nodejs#10057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Switch assert.equal to assert.strictEqual. PR-URL: nodejs#10057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Switch assert.equal to assert.strictEqual. PR-URL: #10057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Switch assert.equal to assert.strictEqual. PR-URL: #10057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Switch assert.equal to assert.strictEqual. PR-URL: #10057 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 21, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.processIssues and PRs related to the process subsystem.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@Exlipse7@addaleax@Trott@cjihrig@mscdex@MylesBorins@imyller@nodejs-github-bot