doc: var => const in js code examples of addons.md#10092
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added addons 
gibfahn approved these changes Dec 2, 2016
silverwind approved these changes Dec 3, 2016
targos approved these changes Dec 3, 2016
Contributor
silverwind commented Dec 3, 2016
Thanks! Landed in 7be1f18. |
silverwind pushed a commit that referenced this pull request Dec 3, 2016
PR-URL: #10092 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
ContributorAuthor
Thank you for the reviews. If somebody has some time, could you also look at #9795, it becomes a bit stale. |
addaleax pushed a commit that referenced this pull request Dec 5, 2016
PR-URL: #10092 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
PR-URL: nodejs#10092 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
PR-URL: #10092 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
PR-URL: #10092 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, addons