doc: add some info on tty#setRawMode()#10147
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fishrock123 added doc 
nodejs-github-bot added doc 
cjihrig reviewed Dec 6, 2016
doc/api/tty.md Outdated
Fishrock123force-pushed the tty-rawmode-docs branch from 490707d to 6a63f9aCompare
jasnell approved these changes Dec 6, 2016
addaleax reviewed Dec 6, 2016
doc/api/tty.md Outdated
Member
There was a problem hiding this comment.
nit: I’d just call them “modifiers”, I don’t think they count as characters in any meaningful context
Contributor
There was a problem hiding this comment.
You could probably just use a comma instead of parentheses.
doc/api/tty.md Outdated
Member
There was a problem hiding this comment.
Why For `stdin` ? This applies to all tty.ReadStreams equally
ContributorAuthor
There was a problem hiding this comment.
Well stdout doesn't usually receive this kind of input? Honestly I'm not really sure what this does to stdout...
doc/api/tty.md Outdated
Member
There was a problem hiding this comment.
Maybe expand “echoing” to “echoing input characters” for clarity
cjihrig reviewed Dec 6, 2016
doc/api/tty.md Outdated
Contributor
There was a problem hiding this comment.
I'm not sure the best way to improve it, but this sentence in parens looks off.
Fishrock123force-pushed the tty-rawmode-docs branch from 6a63f9a to 4238eb7Compareaddaleax approved these changes Dec 7, 2016
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
I still wonder why stdin is being explicitly mentioned in the added text but other than that LGTM
cjihrig approved these changes Dec 8, 2016
Fishrock123force-pushed the tty-rawmode-docs branch from 4238eb7 to b58aa76Compare
ContributorAuthor
Fishrock123 commented Dec 8, 2016
@addaleax LGTY? |
Partially taken from https://linux.die.net/man/3/cfmakeraw A very simple test script: ``` if (process.argv[2] === 'raw') process.stdin.setRawMode(true) process.stdin.on('data', (chunk) =>{console.log(chunk) console.log(chunk.toString()) }) ``` Refs: nodejs#10037 PR-URL: nodejs#10147 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fishrock123force-pushed the tty-rawmode-docs branch from b58aa76 to a0a6ff2CompareFishrock123 added a commit that referenced this pull request Dec 13, 2016
Partially taken from https://linux.die.net/man/3/cfmakeraw A very simple test script: ``` if (process.argv[2] === 'raw') process.stdin.setRawMode(true) process.stdin.on('data', (chunk) =>{console.log(chunk) console.log(chunk.toString()) }) ``` Refs: #10037 PR-URL: #10147 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 16, 2017
Partially taken from https://linux.die.net/man/3/cfmakeraw A very simple test script: ``` if (process.argv[2] === 'raw') process.stdin.setRawMode(true) process.stdin.on('data', (chunk) =>{console.log(chunk) console.log(chunk.toString()) }) ``` Refs: #10037 PR-URL: #10147 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Partially taken from https://linux.die.net/man/3/cfmakeraw A very simple test script: ``` if (process.argv[2] === 'raw') process.stdin.setRawMode(true) process.stdin.on('data', (chunk) =>{console.log(chunk) console.log(chunk.toString()) }) ``` Refs: #10037 PR-URL: #10147 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Partially taken from https://linux.die.net/man/3/cfmakeraw A very simple test script: ``` if (process.argv[2] === 'raw') process.stdin.setRawMode(true) process.stdin.on('data', (chunk) =>{console.log(chunk) console.log(chunk.toString()) }) ``` Refs: #10037 PR-URL: #10147 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, tty
Description of change
Partially taken from https://linux.die.net/man/3/cfmakeraw
A very simple test script:
Related to #10037
Refs(?): http://docs.libuv.org/en/v1.x/tty.html#c.uv_tty_mode_t