test: increase test coverage of BufferList#10171
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
joyeecheungforce-pushed the test-buffer-list branch 3 times, most recently from 887e1ea to 4842402Compare
Contributor
Fishrock123 left a comment
Fishrock123 left a comment There was a problem hiding this comment.
Seems ok otherwise, CI: https://ci.nodejs.org/job/node-test-pull-request/5293/
MemberAuthor
There was a problem hiding this comment.
Thanks for pointing this out. Addressed.
MemberAuthor
There was a problem hiding this comment.
Thanks for pointing this out. Addressed.
Member
Trott commented Dec 7, 2016
CI: https://ci.nodejs.org/job/node-test-pull-request/5296/ EDIT: Whoops, CI was already run. Sorry for the duplicate. It was ✅ green already... |
cjihrig approved these changes Dec 7, 2016
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
LGTM once it's moved to const and let.
Add tests for edges cases of BufferList - test operations when the length is 0 - test operations when the list only has one element
joyeecheungforce-pushed the test-buffer-list branch from 4842402 to a136e2dCompare
MemberAuthor
joyeecheung commented Dec 8, 2016
Thank you for the review, I've updated the |
addaleax approved these changes Dec 8, 2016
Member
addaleax commented Dec 8, 2016
italoacasas commented Dec 8, 2016
Landed f0da38a Thanks for the contribution. |
Member
addaleax commented Dec 8, 2016
@italoacasas I don’t think this is a problem in this case but try to keep the 48/72 hour rule for landing PRs in mind :) |
Fishrock123 pushed a commit that referenced this pull request Dec 13, 2016
Add tests for edges cases of BufferList: - test operations when the length is 0 - test operations when the list only has one element PR-URL: #10171 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 16, 2017
Add tests for edges cases of BufferList: - test operations when the length is 0 - test operations when the list only has one element PR-URL: #10171 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Add tests for edges cases of BufferList: - test operations when the length is 0 - test operations when the list only has one element PR-URL: #10171 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Add tests for edges cases of BufferList: - test operations when the length is 0 - test operations when the list only has one element PR-URL: #10171 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Add tests for edges cases of BufferList