stream_base: homogenize req_wrap_obj use#10184
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Always use `req_wrap_obj` to allow calling `req->Done()` in stream implementations.
indutny added the c++ 
nodejs-github-bot added c++ 
mscdex reviewed Dec 8, 2016
src/stream_base.cc Outdated
| req_wrap->object()->Set(env->bytes_string(), | ||
| req_wrap_obj->Set(env->async(), True(env->isolate())); | ||
| req_wrap_obj->Set(env->bytes_string(), | ||
| Number::New(env->isolate(), bytes)); |
Contributor
There was a problem hiding this comment.
The indentation needs to be adjusted here.
addaleax approved these changes Dec 8, 2016
MemberAuthor
indutny commented Dec 8, 2016
bnoordhuis approved these changes Dec 8, 2016
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
LGTM but you might as well change the one at line ~330 too.
MemberAuthor
indutny commented Dec 8, 2016
@bnoordhuis good point, fixed it everywhere. |
MemberAuthor
indutny commented Dec 8, 2016
bnoordhuis approved these changes Dec 8, 2016
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
LGTM with style nits. Please be less hasty next time.
src/stream_base.cc Outdated
| if (req_wrap->object()->Has(env->context(), | ||
| if (req_wrap_obj->Has(env->context(), | ||
| env->oncomplete_string()).FromJust()){ |
src/stream_base.cc Outdated
| if (req_wrap->object()->Has(env->context(), | ||
| if (req_wrap_obj->Has(env->context(), | ||
| env->oncomplete_string()).FromJust()){ |
cjihrig approved these changes Dec 9, 2016
MemberAuthor
indutny commented Dec 19, 2016
Landed in 729fecf, thank you! |
indutny added a commit that referenced this pull request Dec 19, 2016
Always use `req_wrap_obj` to allow calling `req->Done()` in stream implementations. PR-URL: #10184 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 20, 2016
Always use `req_wrap_obj` to allow calling `req->Done()` in stream implementations. PR-URL: nodejs#10184 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
Always use `req_wrap_obj` to allow calling `req->Done()` in stream implementations. PR-URL: #10184 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
MylesBorins commented Jan 22, 2017
@indutny I've gone ahead and backported to v6.x. It is not landing cleanly on v4.x though please feel free to manually backport. If it should be backported please change the label appropriately. |
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
Always use `req_wrap_obj` to allow calling `req->Done()` in stream implementations. PR-URL: #10184 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
indutny commented Jan 23, 2017
No need to backport it, but thanks for attempt! |
Contributor
MylesBorins commented Jan 23, 2017
@indutny should it be removed from v6.x? |
MemberAuthor
indutny commented Jan 23, 2017
No need to remove it either. It is very minor and has neglectable behavior changes for core internals. |
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Always use `req_wrap_obj` to allow calling `req->Done()` in stream implementations. PR-URL: #10184 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Always use `req_wrap_obj` to allow calling `req->Done()` in stream implementations. PR-URL: #10184 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
stream_base
Description of change
Always use
req_wrap_objto allow callingreq->Done()in streamimplementations.