Skip to content

test: refactor assert.equal, update syntax to ES6#10190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

test: refactor assert.equal, update syntax to ES6 #10190

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@TrottTrott commented Dec 9, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test buffer

Description of change

alternative for #9914

@TrottTrott added buffer Issues and PRs related to the buffer subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. labels Dec 9, 2016
@TrottTrott mentioned this pull request Dec 9, 2016
Closed
3 tasks
@Trott
Copy link
MemberAuthor

Trott commented Dec 9, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5338/

@Trott
Copy link
MemberAuthor

Trott commented Dec 9, 2016

cc / fyi @prietoguy

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 12, 2016
@Trott
test: refactor assert.equal, update syntax to ES6
10891a1
PR-URL: nodejs#10190 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@Trott
Copy link
MemberAuthor

Trott commented Dec 12, 2016

Landed in 10891a1.

Thanks for the contribution, @prietoguy! 🎉

@TrottTrott closed this Dec 12, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 13, 2016
@Fishrock123
test: refactor assert.equal, update syntax to ES6
8b698d8
PR-URL: #10190 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@italoacasasitaloacasas mentioned this pull request Dec 15, 2016
Merged
@TrottTrott deleted the nina-code-learn-2016 branch January 13, 2022 22:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes

+2 more reviewers

@thefourtheyethefourtheyethefourtheye approved these changes

@gibfahngibfahngibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bufferIssues and PRs related to the buffer subsystem.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@thefourtheye@cjihrig@gibfahn@MylesBorins