test: fix setTimeout, add const, remove unused var#10207
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added dont-land-on-v7.x test 
Trott approved these changes Dec 9, 2016
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
LGTM if CI is ✅ .
Not sure why the bot labeled it don't-land-on-v7--maybe it sees a modified test and thinks it might be a behavior change?
Member
Trott commented Dec 9, 2016
ContributorAuthor
sidthekidder commented Dec 10, 2016
The CI check failed on |
Member
Trott commented Dec 10, 2016
The Raspberry Pi that failed had its failure during build and not test. That particular job doesn't run this test anyway. And that particular Raspberry Pi was having build failures throughout the day. (One of the admins rebooted it after I brought it to their attention, but that was after this CI run.) In short, the single CI failure is unrelated and can be ignored. |
santigimeno approved these changes Dec 10, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 14, 2016
apply setTimeout duration, add const, remove unused var PR-URL: nodejs#10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Member
Trott commented Dec 14, 2016
Landed in ca58e53. |
MylesBorins pushed a commit that referenced this pull request Dec 15, 2016
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test/parallel/test-domain.js
Description of change
Added 1ms delay for setTimeout and setInterval, instead of default 0. Changed var->const in 4 places. Removed unused function parameter.