doc: fix broken link in COLLABORATOR_GUIDE.md#10267
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
sam-github commented Dec 14, 2016
LGTM |
Trott reviewed Dec 14, 2016
COLLABORATOR_GUIDE.md Outdated
Member
There was a problem hiding this comment.
Tiniest of nits but might it be better to use one of the relative URLS ./CONTRIBUTING.md#step-3-commit or CONTRIBUTING.md#step-3-commit rather than the FQDN etc.? This way, if you're looking at the doc on a different branch, the link goes to the doc as it exists on that branch rather than to master. The problem with the current link is the .. at the start.
Member
There was a problem hiding this comment.
And if you're going to do that, you could probably fix the one on L129 as well.
Member
gibfahn commented Dec 15, 2016
nit: s/broke/broken in the commit message |
One of the links to CONTRIBUTING.md was broken in the doc. Updated broken link to be the same as the other one in the doc that was working.
MemberAuthor
mhdawson commented Dec 15, 2016
Ok addressed comments so far. |
gibfahn approved these changes Dec 15, 2016
lpinca approved these changes Dec 15, 2016
Contributor
oops i missed the second line. |
MemberAuthor
mhdawson commented Dec 15, 2016
Heading out on vacation so won't land until Jan, anybody else feel free to do so once the waiting time has passed. |
italoacasas approved these changes Dec 16, 2016
cjihrig approved these changes Dec 16, 2016
silverwind approved these changes Dec 16, 2016
Contributor
silverwind commented Dec 16, 2016
Thanks! Landed in 9de2adc. |
silverwind pushed a commit that referenced this pull request Dec 16, 2016
One of the links to CONTRIBUTING.md was broken in the doc. Updated broken link to be the same as the other one in the doc that was working. PR-URL: #10267 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
italoacasas pushed a commit that referenced this pull request Dec 17, 2016
One of the links to CONTRIBUTING.md was broken in the doc. Updated broken link to be the same as the other one in the doc that was working. PR-URL: #10267 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
One of the links to CONTRIBUTING.md was broken in the doc. Updated broken link to be the same as the other one in the doc that was working. PR-URL: #10267 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
One of the links to CONTRIBUTING.md was broken in the doc. Updated broken link to be the same as the other one in the doc that was working. PR-URL: #10267 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
One of the links to CONTRIBUTING.md was broken in the doc. Updated broken link to be the same as the other one in the doc that was working. PR-URL: #10267 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
One of the links to CONTRIBUTING.md was broken in the doc. Updated broken link to be the same as the other one in the doc that was working. PR-URL: #10267 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc
Description of change
One of the links to CONTRIBUTING.md was broke in the doc.
Updated broken link to be the same as the other one in the
doc that was working.