test: improve test-child-process-fork-and-spawn#10273
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added test 
santigimeno approved these changes Dec 15, 2016
Member
There was a problem hiding this comment.
I think you can remove the process.nextTick(process.exit);
Member
santigimeno commented Dec 15, 2016
evanlucas approved these changes Dec 15, 2016
Contributor
evanlucas left a comment
evanlucas left a comment There was a problem hiding this comment.
LGTM with @santigimeno's suggestion
lpinca approved these changes Dec 15, 2016
edsadrforce-pushed the child-process-fork branch from a0ccada to f1ec74fCompare
MemberAuthor
edsadr commented Dec 15, 2016
Implemented @santigimeno suggestion, @lpinca could you please set the CI again? |
Member
lpinca commented Dec 15, 2016
cjihrig approved these changes Dec 16, 2016
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
The changes LGTM. Would you mind also updating the assert(0); to use common.fail()?
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * remove unnecessary process.nextTick
edsadrforce-pushed the child-process-fork branch from f1ec74f to 8a4bc9eCompareMemberAuthor
edsadr commented Dec 17, 2016
@cjihrig just changed |
Member
JungMinu commented Dec 17, 2016
italoacasas approved these changes Dec 18, 2016
italoacasas commented Dec 19, 2016
Landed 8b367c5 |
italoacasas pushed a commit that referenced this pull request Dec 19, 2016
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * remove unnecessary process.nextTick PR-URL: #10273 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 20, 2016
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * remove unnecessary process.nextTick PR-URL: nodejs#10273 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * remove unnecessary process.nextTick PR-URL: #10273 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * remove unnecessary process.nextTick PR-URL: #10273 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * remove unnecessary process.nextTick PR-URL: #10273 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * remove unnecessary process.nextTick PR-URL: #10273 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change