test: clean up test-domain-no-error-handler-abort-on-uncaught.js#10291
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added duration to setTimeout and removed extraneous callback args, as per Rich Trott's instructions
nodejs-github-bot added test 
santigimeno approved these changes Dec 15, 2016
Member
santigimeno commented Dec 15, 2016
ContributorAuthor
weyj4 commented Dec 15, 2016
@Trott it failed test/arm. I'm not familiar with Jenkins, don't see anything wrong in the logs though. |
italoacasas commented Dec 16, 2016
@weyj4 the job failing is not related with you PR. |
italoacasas approved these changes Dec 16, 2016
Member
Trott commented Dec 16, 2016
It's even more than that: The job didn't fail at all. The widget is misreporting. I'm not sure why/how. But if you click through on the CI link in #10291 (comment), you'll see that test-arm passed. CI is ✅ |
Member
santigimeno commented Dec 17, 2016
santigimeno pushed a commit that referenced this pull request Dec 17, 2016
Added duration to setTimeout and removed extraneous callback args, as per Rich Trott's instructions PR-URL: #10291 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
italoacasas pushed a commit that referenced this pull request Dec 17, 2016
Added duration to setTimeout and removed extraneous callback args, as per Rich Trott's instructions PR-URL: #10291 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
Added duration to setTimeout and removed extraneous callback args, as per Rich Trott's instructions PR-URL: #10291 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
Added duration to setTimeout and removed extraneous callback args, as per Rich Trott's instructions PR-URL: #10291 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
Added duration to setTimeout and removed extraneous callback args, as per Rich Trott's instructions PR-URL: #10291 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Added duration to setTimeout and removed extraneous callback args, as per Rich Trott's instructions PR-URL: #10291 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Added duration to setTimeout and removed extraneous callback args, as per Rich Trott's instructions PR-URL: #10291 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Added duration to setTimeout and removed extraneous callback args, as per Rich Trott's instructions PR-URL: #10291 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
Added duration to setTimeout and removed extraneous callback args, as per Rich Trott's instructions PR-URL: #10291 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passescommit message follows commit guidelines
Affected core subsystem(s)
test
Description of change
added duration to setTimeout and removed extraneous callback args,
as per Rich Trott's instructions