doc: killSignal option accepts integer values#10424
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`killSignal` option accepts the signal name or signal number as well.
nodejs-github-bot added child_process 
3 tasks
julianduque approved these changes Dec 23, 2016
Contributor
sam-github commented Dec 25, 2016
Is this behaviour covered by tests? |
ContributorAuthor
thefourtheye commented Dec 26, 2016
@sam-github There are few cases in test/parallel/test-child-process-spawnsync-validation-errors.js, but #10423 has enough cases I believe. |
jasnell approved these changes Dec 26, 2016
Contributor
sam-github commented Dec 28, 2016
ContributorAuthor
thefourtheye commented Dec 28, 2016
@sam-github This behaviour is already there. #10423 improves the validation. |
Contributor
sam-github commented Dec 28, 2016
I suggest putting docs and tests in the same commit in the future, it makes them "obviously correct". But LGTM as is. |
Member
|
jasnell pushed a commit that referenced this pull request Jan 6, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: #10424 Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Member
jasnell commented Jan 6, 2017
Landed in fc647fd |
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Merged
thefourtheye added a commit to thefourtheye/io.js that referenced this pull request Feb 5, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
2 tasks
thefourtheye added a commit to thefourtheye/io.js that referenced this pull request Feb 5, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
2 tasks
MylesBorins pushed a commit that referenced this pull request Feb 6, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: #10424 Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: #10424 Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: #10424 Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc child_process
Description of change
killSignaloption accepts the signal name or signal number as well.