v6.x: build: remove node.dsYM directory#10463
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It was added by mistake in nodejs@d283704
targos changed the title 
MemberAuthor
targos commented Dec 26, 2016
/cc @thealphanerd |
Contributor
MylesBorins commented Dec 26, 2016
lgtm! thanks for noticing. should we add it to the git ignore? |
jasnell approved these changes Dec 26, 2016
cjihrig approved these changes Dec 26, 2016
jbergstroem approved these changes Dec 27, 2016
MylesBorins pushed a commit that referenced this pull request Dec 27, 2016
It was added by mistake in d283704 PR-URL: #10463 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Contributor
MylesBorins commented Dec 27, 2016
landed in 868e5e6 |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was added by mistake in
d283704