Skip to content

test: improve code in test-console-instance#10813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
edsadr wants to merge 1 commit into from
Closed

test: improve code in test-console-instance #10813

edsadr wants to merge 1 commit into from

Conversation

@edsadr
Copy link
Member

@edsadredsadr commented Jan 15, 2017

  • use common.mustCall to validate functions executions
  • improve error validations
  • remove unnecessary assertions
  • use arrow functions
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 15, 2017
@mscdexmscdex added console Issues and PRs related to the console subsystem. and removed dont-land-on-v7.x labels Jan 15, 2017
@santigimeno
Copy link
Member

santigimeno commented Jan 15, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5864/

lpinca
lpinca reviewed Jan 15, 2017
View reviewed changes
test/parallel/test-console-instance.js Outdated
Copy link
Member

@lpincalpincaJan 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: template literal?

@edsadr
Copy link
MemberAuthor

edsadr commented Jan 15, 2017

@lpinca did the nit, please set the CI again

@lpinca
Copy link
Member

lpinca commented Jan 15, 2017•
edited
Loading

New CI: https://ci.nodejs.org/job/node-test-pull-request/5868/

cjihrig
cjihrig requested changes Jan 15, 2017
View reviewed changes
test/parallel/test-console-instance.js Outdated
Copy link
Contributor

@cjihrigcjihrigJan 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of the custom function, can you use common.fail().

@edsadr
test: improve code in test-console-instance
e8dc171
* use common.mustCall to validate functions executions * use common.fail to check test fail * improve error validations * remove unnecessary assertions * use arrow functions
@edsadr
Copy link
MemberAuthor

edsadr commented Jan 17, 2017

@cjihrig , did the change

@italoacasas
Copy link

italoacasas commented Jan 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5901/console

@italoacasas
Copy link

italoacasas commented Jan 17, 2017

Landed 8e491a4

italoacasas pushed a commit that referenced this pull request Jan 17, 2017
@edsadr
test: improve code in test-console-instance
8e491a4
* use common.mustCall to validate functions executions * use common.fail to check test fail * improve error validations * remove unnecessary assertions * use arrow functions PR-URL: #10813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@edsadr
test: improve code in test-console-instance
34c0326
* use common.mustCall to validate functions executions * use common.fail to check test fail * improve error validations * remove unnecessary assertions * use arrow functions PR-URL: nodejs#10813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@edsadr
test: improve code in test-console-instance
675a292
* use common.mustCall to validate functions executions * use common.fail to check test fail * improve error validations * remove unnecessary assertions * use arrow functions PR-URL: nodejs#10813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@italoacasasitaloacasas mentioned this pull request Jan 25, 2017
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
@edsadr@targos
test: improve code in test-console-instance
bf585c1
* use common.mustCall to validate functions executions * use common.fail to check test fail * improve error validations * remove unnecessary assertions * use arrow functions PR-URL: #10813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@italoacasasitaloacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadr
test: improve code in test-console-instance
1666600
* use common.mustCall to validate functions executions * use common.fail to check test fail * improve error validations * remove unnecessary assertions * use arrow functions PR-URL: nodejs#10813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadr
test: improve code in test-console-instance
89a1eb3
* use common.mustCall to validate functions executions * use common.fail to check test fail * improve error validations * remove unnecessary assertions * use arrow functions PR-URL: nodejs#10813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@edsadr@jasnell
test: improve code in test-console-instance
a7a8681
* use common.mustCall to validate functions executions * use common.fail to check test fail * improve error validations * remove unnecessary assertions * use arrow functions PR-URL: #10813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@edsadr@jasnell
test: improve code in test-console-instance
ba4d56e
* use common.mustCall to validate functions executions * use common.fail to check test fail * improve error validations * remove unnecessary assertions * use arrow functions PR-URL: #10813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@edsadr@MylesBorins
test: improve code in test-console-instance
c91d873
* use common.mustCall to validate functions executions * use common.fail to check test fail * improve error validations * remove unnecessary assertions * use arrow functions PR-URL: #10813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@edsadr@MylesBorins
test: improve code in test-console-instance
017afd4
* use common.mustCall to validate functions executions * use common.fail to check test fail * improve error validations * remove unnecessary assertions * use arrow functions PR-URL: #10813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2017
Merged
@adamlaskaadamlaska mentioned this pull request Nov 25, 2023
Open
@alisccoaliscco mentioned this pull request Nov 28, 2023
Open
@leonardoadameleonardoadame mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 28, 2023
Open
Open
This was referenced Nov 29, 2023
Open
Open
This was referenced Nov 29, 2023
Open
Open
Open
@leonardoadameleonardoadame mentioned this pull request Nov 29, 2023
Open
@alisccoaliscco mentioned this pull request Nov 29, 2023
Open
@leonardoadameleonardoadame mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 30, 2023
Open
Open
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

consoleIssues and PRs related to the console subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@edsadr@santigimeno@lpinca@italoacasas@jasnell@cjihrig@mscdex@nodejs-github-bot