test: add dgram.Socket.prototype.sendto's test#10901
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added test 
cjihrig requested changes Jan 19, 2017
test/parallel/test-dgram-sendto.js Outdated
Contributor
There was a problem hiding this comment.
Can you store this regular expression in a variable for reuse.
hiroppyforce-pushed the feature/add-test-dgram-sendto branch from 0dc8717 to df5c0faCompare
cjihrig requested changes Jan 20, 2017
test/parallel/test-dgram-sendto.js Outdated
Contributor
There was a problem hiding this comment.
No need for the RegExp() constructor.
test/parallel/test-dgram-sendto.js Outdated
Contributor
There was a problem hiding this comment.
If all the sendto() calls are supposed to throw before actually sending, and we're verifying the error messages, I don't think binding, listening, and closing the socket is necessary.
hiroppyforce-pushed the feature/add-test-dgram-sendto branch from df5c0fa to 108934dComparehiroppyforce-pushed the feature/add-test-dgram-sendto branch from 108934d to 8ff8f9cCompare
Member
Trott commented Jan 20, 2017
LGTM if CI is green. I'd leave a nit suggesting being more specific with the identifier name than just |
cjihrig approved these changes Jan 20, 2017
targos approved these changes Jan 22, 2017
Member
targos commented Jan 22, 2017
CI: https://ci.nodejs.org/job/node-test-pull-request/5982/ Tip for the link reference you put in the commit message: You can press |
hiroppyforce-pushed the feature/add-test-dgram-sendto branch from 8ff8f9c to 5bacf6eCompare
MemberAuthor
hiroppy commented Jan 23, 2017
@targos Thanks :) I modified this commit message. |
jasnell approved these changes Jan 23, 2017
Member
targos commented Jan 24, 2017
Landed in 320108c |
targos pushed a commit that referenced this pull request Jan 24, 2017
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: #10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: nodejs#10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: nodejs#10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: nodejs#10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: nodejs#10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: #10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Contributor
MylesBorins commented Mar 8, 2017
failures on v4.x, did not land |
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: #10901 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendto: https://github.com/nodejs/node/blob/master/lib/dgram.js#L234
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test