test: increase coverage of internal/util#10964
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added test 
There was a problem hiding this comment.
Does this pass make lint? The comma should be on the previous line.
There was a problem hiding this comment.
The regex should include. ^ and $.
There was a problem hiding this comment.
Why not use assert.doesNotThrow()?
DavidCai1111 commented Jan 23, 2017
@cjihrig OK, updated :) |
| @@ -0,0 +1,12 @@ | |||
| // Flags: --expose-internals | |||
There was a problem hiding this comment.
FWIW, this test won't actually increase test coverage reported at coverage.nodejs.org unless it is run with Node without crypto. And then, it would lose coverage on the else condition.
addaleax commented Jan 29, 2017
jasnell commented Jan 30, 2017
Failures in CI appear to be unrelated. |
PR-URL: #10964 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell commented Jan 30, 2017
Landed in a7172b5 |
PR-URL: #10964 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #10964 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins commented Mar 8, 2017
I had to revert this from v6.x-staging due to an error It would appear that |
jasnell commented Mar 8, 2017
Odd... I was certain I had run that test locally. Likely missing another commit. This one is likely safe to omit |
MylesBorins commented Apr 17, 2017
if this gets backported it should come with #11620 |
8 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test