deps: upgrade npm to 4.1.2

[zkat]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

• deps

Description of Change

• This PR supersedes deps: upgrade npm to 4.1.1 #10781.
• Record and report success metrics npm/npm#15084 Adds opt-in anonymous success/fail metrics reporting.
• Add new subcommand npm doctor npm/npm#14582 Adds the new npm doctor command.
• Ensure late errors on requests are passed through properly npm/npm-registry-client#148 Bug fix to a major source of shasum-mismatch errors.
• save: stop using url.format for relative local dep paths npm/npm#15114 Fix file URL handling with Node.js 7+.
• npm/npm@c7bbba8 Support for [email protected] officially dropped.
• doesn't honour symbolic links, as writeFile does npm/write-file-atomic#5 Fix writing to symlinked package.json, npm-shrinkwrap.json, or .npmrc.

Additional notes

Heads-up that npm@next is currently a semver-minor bump to [email protected] which includes a significant improvement for search. We'll downstream it in two weeks but it might be worth pointing out that bump cause it's something folks might want in LTS (specially since it has to do with a side utility/service rather than installation and the like). Cheers!

Changelogs

• v4.1.0
• v4.1.1
• v4.1.2

r: @Fishrock123
r: @jasnell
r: @addaleax

[jasnell]

@zkat ... I appreciate this. It would be helpful if you would consider adding links to the relevant commits/PRs for each of the "description of change" bullet points. In particular I'd like to review the file URL changes a bit more in detail to understand more about what is happening there. I will try to give this a review by early next week

[Fishrock123]

@zkat oh no.

Our old friend is back... in a new form:

Applying: deps: upgrade npm to 4.1.2 error: deps/npm/node_modules/request/node_modules/form-data/README.md: already exists in working directory Patch failed at 0001 deps: upgrade npm to 4.1.2 

[Fishrock123]

@zkat In the mean time I'm going to merge #10781, can you rebase after and then we can try to fix that? :D

[Fishrock123]

Ok, 4.1.1 merged. I guess the best way forward here is to rename the file in a separate commit first and then do the rest including whatever changed within the file?

[zkat]

@Fishrock123 I'm so angry. I'm so so angry. I hate git so much sometimes. I hate OSX's (and Windows') wobbly bullshit with case-insensitivity. I hate joy and happyness.... anyway yeah that sounds like a good plan. I'll try it again in a wee bit.

@jasnell Yeah, one sec and I'll look those up for you. Watch for an edit in a few minutes.

[zkat]

@Fishrock123 I rebased and did --whitespace=fix again on mine and ran into no issues. You should definitely be able to merge through the GH UI now, but you may have to do some local maneuvering if you're still running into this shit locally. I'm sorry. I've tried. 😭

[zkat]

@jasnell incidentally, the url.format patch: the only change made was literally just that we stopped using it in one tiny case where we really didn't have to, so that's all it took for it to stop affecting us. I don't think it'll need any further changes. This way is safer anyway. But the link is in the edit now. :)

[Fishrock123]

@zkat definitely still running into issues. :/

[zkat]

@Fishrock123 one more try? Just pushed a new one.

[Fishrock123]

@zkat Nice, great work. Seems to land fine. Here's to hoping it doesn't also have lingering side effects.

Curious though, what did you do?

[zkat]

@Fishrock123

git reset head~1 cd deps/npm/(...)/form-data # need to do a two-step move because OSX will noop a plain case-only move mv README.md rm.md mv rm.md Readme.md git add -A && git commit -m 'deps: upgrade npm to 4.1.2'

And then I just check the commit summary to make sure there's not a file addition for README.md.

[targos]

Changes from all commits 1,035 files +919 −21,259

That is cool!

[zkat]

@targos not much to get excited about, imo. that's probably just from some part of the dependency tree being flattened because of recursive dependencies getting updated and thus allowing more deduping.

[targos]

Not much I agree, but the tarball should still be noticeably smaller

[zkat]

@targos absolutely! you're right. And that's actually p. nice.

[Fishrock123]

Test pass, LGTM

[jasnell]

thank you @zkat!

[Fishrock123]

Thanks, landed in afb7c1b!

[joaocgreis]

Was there a CI run on this PR? Anyone still has the link?

[MylesBorins]

when this lands it will need to come with 35e749b