readline: update 6 comparisons to strict#11078
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the readline 
addaleax approved these changes Jan 31, 2017
lpinca approved these changes Jan 31, 2017
Member
hiroppy commented Jan 31, 2017
Member
addaleax commented Jan 31, 2017
Those Windows failures look weird… /cc @Fishrock123@zkat |
jasnell changed the title 
jasnell approved these changes Jan 31, 2017
targos approved these changes Jan 31, 2017
Trott approved these changes Jan 31, 2017
Member
Trott commented Jan 31, 2017
Definitely want a CI run for Windows on this. Should be able to do it once #11085 lands. |
Member
Trott commented Jan 31, 2017
#11085 landed. CI again for Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/6795/ |
Member
Trott commented Jan 31, 2017
Whoops, I rebased onto something that didn't have the fix in place so the build failed again. Once more... CI (for Windows): https://ci.nodejs.org/job/node-test-commit-windows-fanned/6796/ |
Member
addaleax commented Feb 4, 2017
Landed in b869eca – thanks for the PR! |
addaleax pushed a commit that referenced this pull request Feb 4, 2017
PR-URL: #11078 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 5, 2017
PR-URL: nodejs#11078 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
PR-URL: nodejs#11078 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
PR-URL: nodejs#11078 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #11078 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #11078 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #11078 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #11078 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
readline.js, update 6 comparisons to strict comparisons.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes