backport: backporting misaligned "node --help" text to v7.x staging#11114
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build 
Contributor
mscdex commented Feb 2, 2017
@aashil It looks like you targeted the wrong branch. Currently this PR is based against master instead of v7.x-staging. |
ContributorAuthor
Sorry about that. Fixed |
italoacasas approved these changes Feb 2, 2017
Member
jasnell commented Feb 2, 2017
Should the |
ContributorAuthor
aashil commented Feb 3, 2017
Tagging @evanlucas and @Trott. They can answer more on this. |
Member
Trott commented Feb 3, 2017
¯\(ツ)/¯ |
Contributor
joshgav commented Feb 3, 2017
let me look into backporting --inspect-brk today. this PR should land after that one. |
Contributor
joshgav commented Feb 3, 2017
aashilforce-pushed the misaligned-help-text-backport-v7.x-staging branch from fe71c3a to 7ebae4bCompareContributorAuthor
aashil commented Feb 3, 2017
I justed removed the commit and rebased off your branch. |
4 tasks
joshgavforce-pushed the misaligned-help-text-backport-v7.x-staging branch from 7ebae4b to 1398ed6Compare
The alignment of the argument descriptions in the "node --help" text is off. This commit fixes the issue by adding two spaces before each of the argument description. PR-URL: nodejs#10948Fixes: nodejs#10935 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Josh Gavant <[email protected]>
joshgavforce-pushed the misaligned-help-text-backport-v7.x-staging branch from 1398ed6 to 3d49d3bCompareContributor
joshgav commented Feb 7, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
This PR backports commits 5d27cc1 and 6ff3b03 to v7.x-staging.
Reference PR: #10948