test: increase coverage of buffer#11122
Closed
+13 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
joyeecheung approved these changes Feb 2, 2017
Member
There was a problem hiding this comment.
Something like
consterror=/Int/.test(funx) ? /^TypeError:"buffer"argumentmustbeaBufferorUint8Array$/ : /^TypeError:argumentshouldbeaBuffer$/;assert.throws(()=>Buffer.alloc(9)[funx].apply(newUint32Array(1),args),error);would probably be easier to read.
jasnell approved these changes Feb 2, 2017
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
LGTM with @joyeecheung's formatting suggestion
MemberAuthor
DavidCai1111 commented Feb 3, 2017
OK, updated. |
italoacasas approved these changes Feb 3, 2017
hiroppy approved these changes Feb 3, 2017
thefourtheye approved these changes Feb 5, 2017
jasnell pushed a commit that referenced this pull request Feb 6, 2017
PR-URL: #11122 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Member
jasnell commented Feb 6, 2017
Landed in 901cb8c |
italoacasas commented Feb 9, 2017
This is failing in |
Member
This depends on semver-major #10236 which adds support for |
MemberAuthor
DavidCai1111 commented Feb 10, 2017
OK |
3 tasks
italoacasas pushed a commit that referenced this pull request Feb 16, 2017
PR-URL: #11312 Backport-of: #11122 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
PR-URL: #11312 Backport-of: #11122 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
PR-URL: nodejs#11122 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
3 tasks
Member
gibfahn commented Jun 17, 2017
Adding |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test