Skip to content

Conversation

@chiiia12
Copy link

I improved test coverage for readline. I found some key tests are missing. This PR will improve coverage

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

N/A

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 3, 2017
@yosuke-furukawa
Copy link
Member

Hello, @nodejs/collaborators .
I am teaching about how to contribute node.js in my office (like code-and-learn) .
She would like to contribute improvement some tests. please review.

@hiroppyhiroppy added the readline Issues and PRs related to the built-in readline module. label Feb 3, 2017
@hiroppy
Copy link
Member

Hello, chiiia12 and Yosuke!
Thank you for your contribution 😘
This is LGTM but I submitted the same tests before. #10772

@chiiia12chiiia12 closed this Feb 3, 2017
@chiiia12
Copy link
Author

Hello, abouthiroppy!
Thanks for your review!!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readlineIssues and PRs related to the built-in readline module.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@chiiia12@yosuke-furukawa@hiroppy@nodejs-github-bot