doc: adding Italo A. Casas PGP Fingerprint#11202
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
Have you uploaded your (EDIT: public) key to https://sks-keyservers.net/? I can't seem to find you. |
Author
Fixed. |
evanlucas approved these changes Feb 7, 2017
Contributor
evanlucas left a comment
evanlucas left a comment There was a problem hiding this comment.
LGTM, but maybe wait to get signoff from a few other members of @nodejs/release since there are some additional steps to be taken (like getting your public key for promoting the binaries)
jasnell approved these changes Feb 7, 2017
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
LGTM once all the necessary other steps are complete :-)
MylesBorins suggested changes Feb 7, 2017
Contributor
MylesBorins commented Feb 7, 2017
I've verified that |
italoacasasforce-pushed the readme/key-fingerprint branch from 09a1d15 to cdda682CompareAuthor
italoacasas commented Feb 7, 2017
I add the command as requested. Thanks, everyone. |
MylesBorins approved these changes Feb 8, 2017
jasnell pushed a commit that referenced this pull request Feb 11, 2017
PR-URL: #11202 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Member
jasnell commented Feb 11, 2017
Landed in c8fff70 |
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
PR-URL: #11202 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
PR-URL: nodejs#11202 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
PR-URL: nodejs#11202 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #11202 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #11202 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #11202 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #11202 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding my PGP Fingerprint to the release team.
CTC vote: nodejs/CTC#48
I have been doing the first part of the release for the last 2 or 3 releases in the current branch (7.x), this week release (7.6.0) is going to be a small one and is going to be easier for me to do the complete release. I ask Evan Lucas in IRC and he is going to help me in the process.
Pending Items:
cc: @nodejs/release @evanlucas