test: improve buffer.includes error verification tests#11203
Uh oh!
There was an error while loading. Please reload this page.
Conversation
toboid changed the title 
| assert.throws(function(){ | ||
| assert.throws(()=>{ | ||
| b.includes(()=>{}); | ||
| },/^TypeError:"val"argumentmustbestring,number,BufferorUint8Array$/); |
There was a problem hiding this comment.
Can you put this regular expression in a variable so that it can be reused.
fhalde commented Feb 7, 2017
Please prefix the PR with test,buffer tag. Commit message guidelines |
toboidforce-pushed the improve-buffer-includes-tests branch from a694127 to 83c8f29Comparetoboid changed the title 
Gotta mildly disagree with that. Just (EDIT: But if someone did put |
toboid changed the title 
toboid commented Feb 7, 2017
|
Trott commented Feb 7, 2017
toboid commented Feb 7, 2017
Looks like there was an issue with the build server, it started returning http 502, now that its back the above build has disappeared, it's returning http 404. Does CI need to be kicked-off again? |
Trott commented Feb 8, 2017
fhalde commented Feb 8, 2017
@Trott haha. It was supposed to be test or buffer. I wasn't sure what was appropriate for this case. Anyway test it is 😄 |
jasnell commented Feb 8, 2017
CI failures on freebsd are unrelated |
Trott commented Feb 8, 2017
* verify error message * use arrow funcs PR-URL: #11203 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell commented Feb 11, 2017
Landed in 1544d8f |
italoacasas commented Feb 14, 2017
This commit is breaking tests in v7.x, maybe because of some |
* verify error message * use arrow funcs PR-URL: nodejs#11203 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn commented Jun 17, 2017
Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the |
targos commented Jun 19, 2017
I am backporting this with #12270 |
* verify error message * use arrow funcs PR-URL: #11203 Backport-PR-URL: #13785 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
* verify error message * use arrow funcs PR-URL: #11203 Backport-PR-URL: #13785 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
* verify error message * use arrow funcs PR-URL: #11203 Backport-PR-URL: #13785 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
* verify error message * use arrow funcs PR-URL: nodejs/node#11203 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
10 participants
Verify specific errors thrown by
buffer.includesand change tests to use arrow functions as per latest testing guide.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tests, buffer