dgram: remove this aliases#11243
Merged
dgram: remove this aliases #11243
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the dgram 
targos approved these changes Feb 8, 2017
jasnell approved these changes Feb 8, 2017
ContributorAuthor
cjihrig commented Feb 9, 2017
This commit removes self = this style assignments from dgram. PR-URL: nodejs#11243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
2 tasks
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
This commit removes self = this style assignments from dgram. PR-URL: #11243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
This commit removes self = this style assignments from dgram. PR-URL: nodejs#11243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
This commit removes self = this style assignments from dgram. PR-URL: nodejs#11243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
This commit removes self = this style assignments from dgram. PR-URL: #11243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Mar 8, 2017
Landed on v6. Needs a backport if it should land on v4 |
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
This commit removes self = this style assignments from dgram. PR-URL: #11243 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes
self = thisstyle assignments fromdgram.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
dgram