Skip to content

Conversation

@vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, debugger

Fixes: #11250

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 9, 2017
Copy link
Member

@TrottTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott
Copy link
Member

Trott commented Feb 9, 2017

jasnell pushed a commit that referenced this pull request Feb 11, 2017
PR-URL: #11270Fixes: #11250 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

Landed in a29c85a

@jasnelljasnell closed this Feb 11, 2017
@vsemozhetbytvsemozhetbyt deleted the test-debugger-pid branch February 11, 2017 17:02
italoacasas pushed a commit that referenced this pull request Feb 13, 2017
PR-URL: #11270Fixes: #11250 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@jasnell
Copy link
Member

requires a backport PR in order to land on v4

jasnell pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #11270Fixes: #11250 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #11270Fixes: #11250 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vsemozhetbyt@Trott@jasnell@nodejs-github-bot